[hotfix][Connector/JDBC] Remove unnecessary unique fields of PostgreSQL upsert statement #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
leonardBang
reviewed
Feb 6, 2025
...src/main/java/org/apache/flink/connector/jdbc/postgres/database/dialect/PostgresDialect.java
Show resolved
Hide resolved
roseduan
force-pushed
the
improve_postgres_upsert
branch
from
e9f3681 to
3a9ac70
Compare
roseduan
changed the title
leonardBang
reviewed
Feb 6, 2025
...org/apache/flink/connector/jdbc/postgres/database/dialect/PostgresPreparedStatementTest.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/flink/connector/jdbc/postgres/database/dialect/PostgresDialect.java
Show resolved
Hide resolved
…QL upsert statement In PostgreSQL, there is no need to specify the unique key fields in the DO UPDATE SET clause. See more details in https://www.postgresql.org/docs/current/sql-insert.html
roseduan
force-pushed
the
improve_postgres_upsert
branch
from
3a9ac70 to
3e2dfb2
Compare
leonardBang
approved these changes
Feb 7, 2025
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @roseduan for the update, LGTM
|
Awesome work, congrats on your first merged pull request! |
Merged
4 tasks
zm999999
added a commit
to zm999999/flink-connector-jdbc
that referenced
this pull request
Jun 25, 2025
Optimize the Postgresql upsert query to avoid unnecessary execution effort
zm999999
added a commit
to zm999999/flink-connector-jdbc
that referenced
this pull request
Jun 25, 2025
Merge pull request apache#155 from apache/main Optimize the Postgresql upsert query to avoid unnecessary execution effort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PostgreSQL, there is no need to specify the unique key fields in the
DO UPDATE SETclause.See more details in https://www.postgresql.org/docs/current/sql-insert.html