Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[FLINK-14724] [table-planner-blink] Join condition could be simplified in logical phase #10163
What is the purpose of the change
the plan of tpcds q38.sql contains NestedLoopJoin, because it's join condition is CAST(AND(IS NOT DISTINCT FROM($2, $3), IS NOT DISTINCT FROM($1, $4), IS NOT DISTINCT FROM($0, $5))):BOOLEAN, and planner can't find equal join keys from the condition by Join#analyzeCondition. add SimplifyJoinConditionRule into logical phase to simplify join condition
Brief change log
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
Last check on commit 7d12e0a (Wed Dec 04 15:07:27 UTC 2019)
Mention the bot in a comment to re-run the automated checks.
Please see the Pull Request Review Guide for a full explanation of the review process.
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required
The @flinkbot bot supports the following commands: