Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-15307][failover]Rename Subclasses of FailoverStrategy #10848

Closed
wants to merge 1 commit into from
Closed

[FLINK-15307][failover]Rename Subclasses of FailoverStrategy #10848

wants to merge 1 commit into from

Conversation

chendonglin521
Copy link

What is the purpose of the change

Subclasses of FailoverStrategy are easily confused with implementation classes of RestartStrategy
Given that the failover strategy class names are transparent to users

Brief change log

  • *Rename Subclasses of FailoverStrategy *

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit a3f83df (Tue Jan 14 01:09:34 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jan 14, 2020 •
edited

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

zhuzhurk
zhuzhurk reviewed Jan 14, 2020
View reviewed changes
Copy link
Contributor

@zhuzhurk zhuzhurk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @chendonglin521
I left a few comments for it.

@GJL would you also take a look at this change?

...ecutiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGAbortPendingCheckpointsTest.java Outdated
@@ -59,7 +59,7 @@
/**
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG}.
*/
public class AdaptedRestartPipelinedRegionStrategyNGAbortPendingCheckpointsTest extends TestLogger {
public class AdaptedRestartPipelinedRegionFailoverStrategyNGAbortPendingCheckpointsTest extends TestLogger {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not do this since this PR does not rename AdaptedRestartPipelinedRegionStrategyNG.

...me/executiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGConcurrentFailoverTest.java Outdated
@@ -51,7 +51,7 @@
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG} failover handling when concurrent failovers happen.
* There can be local+local and local+global concurrent failovers.
*/
public class AdaptedRestartPipelinedRegionStrategyNGConcurrentFailoverTest extends TestLogger {
public class AdaptedRestartPipelinedRegionFailoverStrategyNGConcurrentFailoverTest extends TestLogger {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's related to a legacy failover strategy AdaptedRestartPipelinedRegionStrategyNG so do not rename it in this PR.

...link/runtime/executiongraph/AdaptedRestartPipelinedRegionFailoverStrategyNGFailoverTest.java Outdated
@@ -63,7 +63,7 @@
/**
* Tests for {@link AdaptedRestartPipelinedRegionStrategyNG} failover handling.
*/
public class AdaptedRestartPipelinedRegionStrategyNGFailoverTest extends TestLogger {
public class AdaptedRestartPipelinedRegionFailoverStrategyNGFailoverTest extends TestLogger {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed. See my other 2 comments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I check carefully and modify.

.../test/java/org/apache/flink/test/checkpointing/ContinuousFileProcessingCheckpointITCase.java Outdated
// TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionStrategy,
// for this ContinuousFileProcessingCheckpointITCase, using RestartPipelinedRegionStrategy would result in endless running.
throw new AssumptionViolatedException("ignored ContinuousFileProcessingCheckpointITCase when using RestartPipelinedRegionStrategy");
// TODO the 'NO_OF_RETRIES' is useless for current RestartPipelinedRegionFailoverStrategy,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not flip. RestartPipelinedRegionStrategy but StreamFaultToleranceTestBase#FailoverStrategy.
I think we need to rename the enums in it as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't agree with you more. I will rename the enums

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhuzhurk Hi zhuzhu, Appreciation of your kind guidance , and I've updated it according to your comments

@zhuzhurk
Copy link
Contributor

Thanks for addressing the comments @chendonglin521 .
The change looks good to me now.

@GJL
Copy link
Member

GJL commented Jan 15, 2020

I am fine with the name changes.

@zhuzhurk
Copy link
Contributor

Thanks for the feedback @GJL .
Merging.

zhuzhurk pushed a commit to zhuzhurk/flink that referenced this pull request Jan 15, 2020
@zhuzhurk
[FLINK-15307][runtime] Rename Subclasses of FailoverStrategy
0640605 
This closes apache#10848.
@zhuzhurk zhuzhurk closed this in 5984e7e Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuzhurk zhuzhurk zhuzhurk left review comments

Assignees
No one assigned
Labels
component=Runtime/Configuration review=description?
Projects
None yet
Milestone
No milestone
5 participants
@chendonglin521 @flinkbot @zhuzhurk @GJL @rmetzger