[FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.#12308
Closed
xintongsong wants to merge 3 commits into
Closed
[FLINK-17721][filesystems][test] Fix test instability for AbstractHadoopFileSystemITTest.#12308xintongsong wants to merge 3 commits into
xintongsong wants to merge 3 commits into
Conversation
Per the JavaDoc of System.nanoTime(), we should use `t1 - t0 < 0` rather than `t1 < t0` because of the possibility of numerical overflow.
…e status checking.
Collaborator
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit dd21b02 (Fri Oct 16 10:54:34 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. DetailsThe Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Collaborator
Contributor
|
The changes look good! But maybe 5 seconds of deadline is not enough? |
Contributor
Author
|
@aljoscha What value do you suggest? Maybe change it back to 30s? |
…ach file status checking.
Contributor
Author
|
I've increased it to 30s. |
Contributor
|
Ok, I think that's good to merge then! I'll merge. |
Contributor
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR fixes test instability for
AbstractHadoopFileSystemITTest. The problem was that a timeout for checking file status is shared by all test cases and may fail if previous test executions take too long.Brief change log
Set independent timeout for each file status checking.
Verifying this change
This PR is a fix for existing test cases.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation