Skip to content

[FLINK-17889][hive] Hive can not work with filesystem connector#12309

Merged
JingsongLi merged 2 commits into
apache:masterfrom
JingsongLi:hiveDeps
May 26, 2020
Merged

[FLINK-17889][hive] Hive can not work with filesystem connector#12309
JingsongLi merged 2 commits into
apache:masterfrom
JingsongLi:hiveDeps

Conversation

@JingsongLi
Copy link
Copy Markdown
Contributor

@JingsongLi JingsongLi commented May 25, 2020

What is the purpose of the change & Brief change log

  • Hive jar should not include format java SPI file. Modify hive pom to exclude SPI file.
  • relocation flink-parquet, Because we have already relocated the dependency of parquet, if we use hive and FS parquet at the same time, no relocation will cause class conflict.

Verifying this change

Manually testing.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 25, 2020

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit f6aec05 (Fri Oct 16 10:54:57 UTC 2020)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

Details
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 25, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@JingsongLi JingsongLi changed the title [FLINK-17889][hive] Hive jar should not include format java service file [FLINK-17889][hive] Hive can not work with filesystem connector May 25, 2020
Copy link
Copy Markdown
Contributor

@lirui-apache lirui-apache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lirui-apache
Copy link
Copy Markdown
Contributor

One minor suggestion: we should use the same package prefix for all the shaded dependencies.

@JingsongLi JingsongLi merged commit ec0288c into apache:master May 26, 2020
JingsongLi added a commit that referenced this pull request May 26, 2020
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
@JingsongLi JingsongLi deleted the hiveDeps branch November 5, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants