Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-18191] Rename jobmanager.memory.* configuration options into master.memory.* #12634

Closed
wants to merge 2 commits into from

Conversation

tillrohrmann
Copy link
Contributor

@tillrohrmann tillrohrmann commented Jun 12, 2020

This commit renames the jobmanager.memory.* config options into master.memory.* to
align it better with the overall Flink terminology.

cc @zentol.

…aster.memory.*

This commit renames the jobmanager.memory.* config options into master.memory.* to
align it better with the overall Flink terminology.
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3756d9a (Fri Jun 12 14:39:01 UTC 2020)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 12, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@tillrohrmann
Copy link
Contributor Author

Thanks for the quick review @zentol. Unfortunately, there is currently a discussion about renaming the "Flink Master" back into the "JobManager" again. Until this discussion is resolved, we need to put this effort on halt, unfortunately.

@zentol
Copy link
Contributor

zentol commented Jun 15, 2020

@tillrohrmann Where is this discussion? I only saw one comment by @aljoscha in FLINK-18209.

@tillrohrmann
Copy link
Contributor Author

Closing this PR since it seems to be no longer relevant.

@tillrohrmann tillrohrmann deleted the FLINK-18191 branch December 15, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants