New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-18191] Rename jobmanager.memory.* configuration options into master.memory.* #12634
Conversation
…aster.memory.* This commit renames the jobmanager.memory.* config options into master.memory.* to align it better with the overall Flink terminology.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3756d9a (Fri Jun 12 14:39:01 UTC 2020) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks for the quick review @zentol. Unfortunately, there is currently a discussion about renaming the "Flink Master" back into the "JobManager" again. Until this discussion is resolved, we need to put this effort on halt, unfortunately. |
@tillrohrmann Where is this discussion? I only saw one comment by @aljoscha in FLINK-18209. |
Closing this PR since it seems to be no longer relevant. |
This commit renames the
jobmanager.memory.*
config options intomaster.memory.*
toalign it better with the overall Flink terminology.
cc @zentol.