New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-17891][yarn] Set execution.target to yarn-session in FlinkYarnSessionCli.run() #12635
Conversation
…sionCli.run() Currently when starting a yarn session cluster using the yarn-session script or the FlinkYarnSessionCli.run() the displayed execution.target is yarn-per-job, which is misleading. We fix it by explicitly setting it to yarn-session.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 6d193f4 (Fri Jun 12 15:07:50 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
This looks good to merge! |
Thanks @kl0u. This is a valid fix to always set the |
…sionCli.run() Currently when starting a yarn session cluster using the yarn-session script or the FlinkYarnSessionCli.run() the displayed execution.target is yarn-per-job, which is misleading. We fix it by explicitly setting it to yarn-session. This closes #12635. (cherry picked from commit cc1f1a4)
…sionCli.run() Currently when starting a yarn session cluster using the yarn-session script or the FlinkYarnSessionCli.run() the displayed execution.target is yarn-per-job, which is misleading. We fix it by explicitly setting it to yarn-session. This closes apache#12635.
…sionCli.run() Currently when starting a yarn session cluster using the yarn-session script or the FlinkYarnSessionCli.run() the displayed execution.target is yarn-per-job, which is misleading. We fix it by explicitly setting it to yarn-session. This closes apache#12635. (cherry picked from commit cc1f1a4)
What is the purpose of the change
Currently, when starting a yarn session cluster using the
yarn-session.sh
script or theFlinkYarnSessionCli.run()
the displayedexecution.target
isyarn-per-job
, which is misleading. We fix it by explicitly setting it toyarn-session
.Brief change log
We simply add a line in the
FlinkYarnSessionCli.run()
that set the correct value in the configuration to be shipped to the cluster.Verifying this change
Was verified manually.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation