Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-17891][yarn] Set execution.target to yarn-session in FlinkYarnSessionCli.run() #12635

Closed
wants to merge 1 commit into from

Conversation

kl0u
Copy link
Contributor

@kl0u kl0u commented Jun 12, 2020

What is the purpose of the change

Currently, when starting a yarn session cluster using the yarn-session.sh script or the FlinkYarnSessionCli.run() the displayed execution.target is yarn-per-job, which is misleading. We fix it by explicitly setting it to yarn-session.

Brief change log

We simply add a line in the FlinkYarnSessionCli.run() that set the correct value in the configuration to be shipped to the cluster.

Verifying this change

Was verified manually.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

…sionCli.run()

Currently when starting a yarn session cluster using the yarn-session script
or the FlinkYarnSessionCli.run() the displayed execution.target is
yarn-per-job, which is misleading. We fix it by explicitly setting it
to yarn-session.
@kl0u kl0u requested a review from aljoscha June 12, 2020 15:03
@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 6d193f4 (Fri Jun 12 15:07:50 UTC 2020)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@kl0u
Copy link
Contributor Author

kl0u commented Jun 12, 2020

@wangyang0918

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 12, 2020

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@aljoscha
Copy link
Contributor

This looks good to merge!

@wangyang0918
Copy link
Contributor

wangyang0918 commented Jun 15, 2020

Thanks @kl0u. This is a valid fix to always set the DeploymentOptions.TARGET to session in FlinkYarnSessionCli#run. I have verified it could take effect. + 1 for merging.

@kl0u kl0u closed this in cc1f1a4 Jun 16, 2020
kl0u added a commit that referenced this pull request Jun 16, 2020
…sionCli.run()

Currently when starting a yarn session cluster using the yarn-session script
or the FlinkYarnSessionCli.run() the displayed execution.target is
yarn-per-job, which is misleading. We fix it by explicitly setting it
to yarn-session.

This closes #12635.

(cherry picked from commit cc1f1a4)
bigdata-ny pushed a commit to bigdata-ny/flink that referenced this pull request Jun 19, 2020
…sionCli.run()

Currently when starting a yarn session cluster using the yarn-session script
or the FlinkYarnSessionCli.run() the displayed execution.target is
yarn-per-job, which is misleading. We fix it by explicitly setting it
to yarn-session.

This closes apache#12635.
zhangjun0x01 pushed a commit to zhangjun0x01/flink that referenced this pull request Jul 8, 2020
…sionCli.run()

Currently when starting a yarn session cluster using the yarn-session script
or the FlinkYarnSessionCli.run() the displayed execution.target is
yarn-per-job, which is misleading. We fix it by explicitly setting it
to yarn-session.

This closes apache#12635.

(cherry picked from commit cc1f1a4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants