[FLINK-18452][table-runtime-blink] Fix StateMigrationException because RetractableTopNFunction#ComparatorWrapper might be incompatible #14150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
TopN query may throw StateMigrationException because the
RetractableTopNFunction#ComparatorWrapper
in serializer might be incompatible. The reason lays inComparatorWrapper
compares the generated code, however code might be differnet when generated in different client.Brief change log
ComparatorWrapper
to compare meta information which is used to generate the code. And rename it toComparableRecordComparator
.Verifying this change
The test is hard to add. We cover this by using
ComparableRecordComparator
in harness unit test.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation