Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor #15250

Merged
merged 1 commit into from Jun 15, 2021

Conversation

hehuiyuan
Copy link
Contributor

What is the purpose of the change

This pull resquest fixes Kafka connector. There is a cast problem when use properties method.

  Properties props = new Properties();
   props.put( "enable.auto.commit", "false");
   props.put( "fetch.max.wait.ms", "3000");
   props.put("flink.poll-timeout", 5000);
   props.put( "flink.partition-discovery.interval-millis", false);

  kafka = new Kafka()
       .version("0.11")
       .topic(topic)
       .properties(props);
Exception in thread "main" java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.String

Exception in thread "main" java.lang.ClassCastException: java.lang.Boolean cannot be cast to java.lang.String

Brief change log

  • change (String) v ----> String.valueOf() in Kafka.java

Documentation

  • Does this pull request introduce a new feature? ( no)

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit ce2ae5e (Sat Aug 28 12:16:38 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Mar 17, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@hehuiyuan
Copy link
Contributor Author

Hi @JingsongLi , who can help look at this problem?

@luoyuxia
Copy link
Contributor

luoyuxia commented Jun 3, 2021

@hehuiyuan
Thank you for your contribution.
Would you like to add tests to cover this change?
I think you can modify KafkaTest directly:
change

properties.put("zookeeper.stuff", "12"); properties.put("kafka.stuff", "42");

->
properties.put("zookeeper.stuff", "12"); properties.put("kafka.stuff", 42);

so that we can ensure your code change works.

@JingsongLi JingsongLi requested review from JingsongLi and removed request for JingsongLi June 3, 2021 08:44
@hehuiyuan
Copy link
Contributor Author

@hehuiyuan
Thank you for your contribution.
Would you like to add tests to cover this change?
I think you can modify KafkaTest directly:
change

properties.put("zookeeper.stuff", "12"); properties.put("kafka.stuff", "42");

->
properties.put("zookeeper.stuff", "12"); properties.put("kafka.stuff", 42);

so that we can ensure your code change works.

ok.

@hehuiyuan
Copy link
Contributor Author

HI @luoyuxia , done.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank @hehuiyuan

@JingsongLi JingsongLi merged commit df92fa9 into apache:master Jun 15, 2021
luoyuxia pushed a commit to luoyuxia/flink that referenced this pull request Jun 21, 2021
jnh5y pushed a commit to jnh5y/flink that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants