New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20318][Connector/kafka]Fix cast question for properies() method in kafka ConnectorDescriptor #15250
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit ce2ae5e (Sat Aug 28 12:16:38 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
dc9db2c
to
7c7d660
Compare
Hi @JingsongLi , who can help look at this problem? |
@hehuiyuan
-> so that we can ensure your code change works. |
ok. |
7c7d660
to
ce2ae5e
Compare
HI @luoyuxia , done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank @hehuiyuan
…a ConnectorDescriptor This closes apache#15250
…a ConnectorDescriptor This closes apache#15250
What is the purpose of the change
This pull resquest fixes Kafka connector. There is a cast problem when use properties method.
Brief change log
Documentation