New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-25795][python][connector/pulsar] Add pulsar sink DataStream API #19682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deadwind4 Thanks for the PR. Have left a few comments. Besides, we should also update the documentation in https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/pulsar/ by adding Python examples.
037425a
to
91d63ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deadwind4 Thanks a lot for the update. Have left a few comments. Besides, it seems that the tests didn't passed and there are checkstyle issues. You could run check style check locally under directory flink-python
as following: ./dev/lint-python.sh sphinx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deadwind4 Thanks for the update. LGTM overall.
Example: | ||
:: | ||
|
||
>>> sink = PulsarSink() \\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> sink = PulsarSink() \\ | |
>>> sink = PulsarSink \\ |
… in PyFlink DataStream API This closes apache#19682.
… in PyFlink DataStream API This closes apache#19682.
… in PyFlink DataStream API This closes apache#19682.
What is the purpose of the change
There is no python pulsar sink API.
Brief change log
Add python pulsar sink.
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: no)Documentation