[FLINK-25565][Formats][Parquet] write and read parquet int64 timestamp#23887
Conversation
apache#18304) Co-authored-by: Thomas Weise <thw@apache.org>
|
@tweise Was this a bug? If so, we should change the type of ticket. Don't forget to add 1.18.1 as a fix version then as well. Edit: Ah it's a subtask, so you can't have a bug type for that. |
|
@MartijnVisser good point - strictly speaking it is a bug, let me add a comment to the ticket. |
| nanosOfMillisecond = value % NANOS_PER_SECOND; | ||
| break; | ||
| default: | ||
| break; |
There was a problem hiding this comment.
No time unit means drop the value? Should we throw an error?
There was a problem hiding this comment.
Good catch. LogicalTypeAnnotation.TimeUnit has only the 3 values that are all covered, so there should neither be a practical danger of dropping the value nor big risk of throwing an exception under default for clarity. It is also more of a stylistic concern that we can deal with in the master branch. I will open a PR there.
There was a problem hiding this comment.
I would throw an exception for defensive programming.
backport #18304