[FLINK-38776][table] Fix incorrect auxiliary group field names #27319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
snuyanzin
reviewed
Dec 4, 2025
| <Resource name="optimized exec plan"> | ||
| <![CDATA[ | ||
| HashWindowAggregate(groupBy=[a4], auxGrouping=[b4], window=[TumblingGroupWindow('w$, d4, 900000)], select=[a4, b4 AS EXPR$2, COUNT(c4) AS EXPR$2]) | ||
| HashWindowAggregate(groupBy=[a4], auxGrouping=[b4], window=[TumblingGroupWindow('w$, d4, 900000)], select=[a4, b4, COUNT(c4) AS EXPR$2]) |
Contributor
There was a problem hiding this comment.
Do I understand correctly that if we have a test like
- unparse optimized version to SQL
- validate SQL
- apply for all (at least compiled plan related) tests then we could potentially spot more issues like that
?
Contributor
There was a problem hiding this comment.
Is it easy/tractable to unparse from the optimized version back to SQL?
Contributor
Author
There was a problem hiding this comment.
AFAIK, we don't currently have automated validation for plans, but this feature looks quite valuable, though the implementation might be challenging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Fix incorrect auxiliary group field names.
Brief change log
Verifying this change
AggregateReduceGroupingTestDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation