[FLINK-39865][ci] Replace abandoned travis-ci artifacts uploader with AWS CLI for nightly S3 upload#28327
Merged
Merged
Conversation
Collaborator
… AWS CLI for nightly S3 upload The nightly "Upload artifacts to S3" step installed the travis-ci/artifacts uploader via `curl ... | bash`. That installer downloads its binary from a hardcoded travis-ci S3 bucket which now returns HTTP 403, so the XML error page was saved as the `artifacts` binary and executed, breaking every nightly run since 2026-06-02. The travis-ci/artifacts project is abandoned. Replace it with the maintained AWS CLI (`aws s3 cp --recursive`), installing AWS CLI v2 in the build container when absent. Credentials are now read from the environment (AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY) instead of being passed as command-line arguments, so they no longer appear in the `set -x` trace. The default (private) ACL and bucket-root upload layout are preserved. Generated-by: Claude Code (Opus 4.8)
328cc91 to
9a4008b
Compare
snuyanzin
approved these changes
Jun 5, 2026
snuyanzin
left a comment
Contributor
There was a problem hiding this comment.
LGTM
thanks for fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The nightly Upload artifacts to S3 step (
flink-ci.flink-master-mirror, definitionId=1) has failed on every run since 2026-06-02:tools/ci/deploy_nightly_to_s3.shinstalls thetravis-ci/artifactsuploader viacurl ... | bash. That installer downloads its binary from a hardcoded travis-ci S3 bucket (s3.amazonaws.com/travis-ci-gmbh/artifacts/...) which now returns HTTP 403 AccessDenied. Because the install writes the response without checking it, the XML error page is saved as theartifactsbinary and executed, producing the syntax error above. Thetravis-ci/artifactsproject is abandoned.Failure history (nightly cron runs):
Brief change log
travis-ci/artifactsuploader intools/ci/deploy_nightly_to_s3.shwithaws s3 cp "$FILES_DIR" "s3://$ARTIFACTS_S3_BUCKET/" --recursive. The recursive copy to the bucket root preserves the previous--target-paths /layout, and the bucket's default (private) ACL matches the travis uploader's default.awsis not already present in the build container (chesnay/flink-cidoes not ship it, but providescurlandunzip).tools/azure-pipelines/build-nightly-dist.yml, map the existing Azure secret variables toAWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY, which the AWS CLI reads from the environment. Credentials are no longer passed as command-line arguments, so they no longer appear in theset -xtrace.Verifying this change
This change is a CI/build-tooling fix and is verified by the nightly pipeline itself. Additionally validated locally:
bash -n tools/ci/deploy_nightly_to_s3.shpasses.aws s3 cp <dir> s3://<bucket>/ --recursive --dryrun) confirms the recursive upload preserves the relative path layout (files land at the bucket root, sub-directories preserved).set -xtrace that the credential values do not appear on theaws s3 cpcommand line.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8)