Skip to content

[BP-1.20][FLINK-38809][Tests] Upgrade Testcontainers to 2.0.5#28335

Merged
snuyanzin merged 2 commits into
apache:release-1.20from
snuyanzin:205_20
Jun 7, 2026
Merged

[BP-1.20][FLINK-38809][Tests] Upgrade Testcontainers to 2.0.5#28335
snuyanzin merged 2 commits into
apache:release-1.20from
snuyanzin:205_20

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

The main idea is to use testcontainers to fix 1.20 ci issue see testcontainers/testcontainers-java#9542

This is a problem of java8(where parsing was not fixed yet) and jackson (it workarounded jdk issue in 2.9.2)
The problem is that in case of 1.x testcontainers shades jackson 2.8.8 (without the fix) and it fails in case of java 8
see repro code at testcontainers/testcontainers-java#9542

In testcontainers 2.x they use jackson 2.18.x so it fixes the problem

Brief change log

Verifying this change

1.20 CI Azure

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): ( no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: ( no)

Documentation

  • Does this pull request introduce a new feature? ( no)
  • If yes, how is the feature documented? (not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@flinkbot

flinkbot commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin snuyanzin changed the title [BP-1.20][FLINK-38809][tests] Bump testcontainers to 2.0.5 [BP-1.20][FLINK-38809][Tests] Upgrade Testcontainers to 2.0.5 Jun 6, 2026
@snuyanzin snuyanzin marked this pull request as ready for review June 6, 2026 15:29

@MartijnVisser MartijnVisser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks for fixing it

Comment thread pom.xml Outdated
<protoc.version>3.21.7</protoc.version>
<okhttp.version>3.14.9</okhttp.version>
<testcontainers.version>1.21.4</testcontainers.version>
<testcontainers.version>2.0.3</testcontainers.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: upgrade Testcontainers to 2.0.5

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label Jun 7, 2026
@snuyanzin

Copy link
Copy Markdown
Contributor Author

thanks for taking a look

@snuyanzin snuyanzin merged commit eb73e1e into apache:release-1.20 Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community. target:release-1.20

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants