[BP-1.20][FLINK-38809][Tests] Upgrade Testcontainers to 2.0.5#28335
Merged
Conversation
Collaborator
MartijnVisser
approved these changes
Jun 6, 2026
MartijnVisser
left a comment
Contributor
There was a problem hiding this comment.
Nice find! Thanks for fixing it
spuru9
approved these changes
Jun 7, 2026
| <protoc.version>3.21.7</protoc.version> | ||
| <okhttp.version>3.14.9</okhttp.version> | ||
| <testcontainers.version>1.21.4</testcontainers.version> | ||
| <testcontainers.version>2.0.3</testcontainers.version> |
Contributor
There was a problem hiding this comment.
nit: upgrade Testcontainers to 2.0.5
Contributor
Author
|
thanks for taking a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The main idea is to use testcontainers to fix 1.20 ci issue see testcontainers/testcontainers-java#9542
This is a problem of java8(where parsing was not fixed yet) and jackson (it workarounded jdk issue in 2.9.2)
The problem is that in case of 1.x testcontainers shades jackson 2.8.8 (without the fix) and it fails in case of java 8
see repro code at testcontainers/testcontainers-java#9542
In testcontainers 2.x they use jackson 2.18.x so it fixes the problem
Brief change log
Verifying this change
1.20 CI Azure
Does this pull request potentially affect one of the following parts:
@Public(Evolving): ( no)Documentation
Was generative AI tooling used to co-author this PR?