[FLINK-39868][table-runtime] Remove per-row logging from parseUrl and subString#28336
Open
raminqaf wants to merge 3 commits into
Open
[FLINK-39868][table-runtime] Remove per-row logging from parseUrl and subString#28336raminqaf wants to merge 3 commits into
raminqaf wants to merge 3 commits into
Conversation
… subString SqlFunctionUtils#parseUrl and #subString logged an ERROR on every row hitting an invalid input (malformed URL, negative substring length). Both already return null on that condition, so the logging only adds hot-path noise without changing behaviour. Remove it. Add integration tests in StringFunctionsITCase covering the null-returning branches plus a sanity case for each, since neither function previously had IT-level coverage.
Collaborator
github-actions
Bot
added
the
community-reviewed
… StringFunctionsITCase Move the PARSE_URL, SUBSTRING and SUBSTR coverage from the legacy ScalarFunctionsTest (ExpressionTestBase) to StringFunctionsITCase (BuiltInFunctionTestBase), so these functions get end-to-end IT coverage instead of expression-only tests. This follows the ongoing migration to the new function-test framework. The ported cases keep the existing happy paths and the null-returning branches. PARSE_URL specs use a small fluent builder so each extracted part reads as one line. The original scala methods are removed; unrelated substring uses in other tests stay.
snuyanzin
reviewed
Jun 8, 2026
Comment on lines
50
to
52
| substrTestCases(), | ||
| translateTestCases(), | ||
| concatenateTestCases()) |
Contributor
There was a problem hiding this comment.
nit: can we have abc order for the whole list here?
Contributor
Author
There was a problem hiding this comment.
Done. It is now sorted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Removing hot path error log of the methods parseURL and subString.
Brief change log
Drop the per-row log calls in SqlFunctionUtils. Both functions already return null on the logged condition, so this is behavior-preserving.
No new type strategy. No behavior change.
Verifying this change
StringFunctionsITCaseDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?