New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] [FLINK-5197] [jm] Ignore outdated JobStatusChanged messages #2896

Closed
wants to merge 1 commit into
base: release-1.1
from

Conversation

Projects
None yet
2 participants
@tillrohrmann
Contributor

tillrohrmann commented Nov 29, 2016

Backport of #2895 for release 1.1 branch.

Outdated JobStatusChanged messages no longer trigger a RemoveJob message but are
logged and ignored. This has the advantage, that an outdated JobStatusChanged message
cannot interfere with a recovered job which can have the same job id.

Review @uce.

[FLINK-5197] [jm] Ignore outdated JobStatusChanged messages
Outdated JobStatusChanged messages no longer trigger a RemoveJob message but are
logged and ignored. This has the advantage, that an outdated JobStatusChanged message
cannot interfere with a recovered job which can have the same job id.
@uce

This comment has been minimized.

Show comment
Hide comment
@uce

uce Nov 29, 2016

Contributor

Good catch! The RemoveJob cannot succeed since is also checking the currentJobs that are checked for JobStatusChanged already. So in the end, the only case where this actually triggers removal is when it interfers with a recovered job as you say. 😨

+1 to merge for 1.1 and #2895 for 1.2.

Contributor

uce commented Nov 29, 2016

Good catch! The RemoveJob cannot succeed since is also checking the currentJobs that are checked for JobStatusChanged already. So in the end, the only case where this actually triggers removal is when it interfers with a recovered job as you say. 😨

+1 to merge for 1.1 and #2895 for 1.2.

@tillrohrmann tillrohrmann changed the title from [FLINK-5197] [jm] Ignore outdated JobStatusChanged messages to [backport] [FLINK-5197] [jm] Ignore outdated JobStatusChanged messages Nov 30, 2016

@tillrohrmann

This comment has been minimized.

Show comment
Hide comment
@tillrohrmann

tillrohrmann Nov 30, 2016

Contributor

Thanks for the review @uce. Failing test cases are unrelated. Merging this PR.

Contributor

tillrohrmann commented Nov 30, 2016

Thanks for the review @uce. Failing test cases are unrelated. Merging this PR.

asfgit pushed a commit that referenced this pull request Nov 30, 2016

[FLINK-5197] [jm] Ignore outdated JobStatusChanged messages
Outdated JobStatusChanged messages no longer trigger a RemoveJob message but are
logged and ignored. This has the advantage, that an outdated JobStatusChanged message
cannot interfere with a recovered job which can have the same job id.

This closes #2896.

@tillrohrmann tillrohrmann deleted the tillrohrmann:backportFixJobStatusChangedMessage branch Dec 5, 2016

skidder added a commit to muxinc/flink that referenced this pull request Dec 27, 2016

[FLINK-5197] [jm] Ignore outdated JobStatusChanged messages
Outdated JobStatusChanged messages no longer trigger a RemoveJob message but are
logged and ignored. This has the advantage, that an outdated JobStatusChanged message
cannot interfere with a recovered job which can have the same job id.

This closes apache#2896.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment