New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-5482] QueryableStateClient does not recover from a failed lookup due to a non-running job #3120

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@NicoK
Contributor

NicoK commented Jan 13, 2017

This PR checks each cached lookup query whether it is complete and removes any failed lookup from the cache in favour of a retry.

An appropriate unit test is added based on existing test code.

NicoK added some commits Jan 12, 2017

[FLINK-5482] fix QueryableStateClient not re-issuing a lookup upon fa…
…ilure

Any failing lookup, e.g. in case the job has not been started yet, previously
remained in the lookup cache and thus future queries did not retry the lookup
and failed. This commit changes the lookup caching code so that completed
and failed futures are removed from the cache and replaced by new lookups.
@uce

This comment has been minimized.

Show comment
Hide comment
@uce

uce Jan 16, 2017

Contributor

Very good catch! Thanks. The change looks good to me.

I will merge it after addressing the inline comment.

Contributor

uce commented Jan 16, 2017

Very good catch! Thanks. The change looks good to me.

I will merge it after addressing the inline comment.

@uce

This comment has been minimized.

Show comment
Hide comment
@uce

uce Jan 20, 2017

Contributor

Build failures are unrelated, merging this. Thanks!

Contributor

uce commented Jan 20, 2017

Build failures are unrelated, merging this. Thanks!

asfgit pushed a commit that referenced this pull request Jan 20, 2017

[FLINK-5507] [queryable state] Remove list variant of asQueryableState
The queryable state "sink" using ListState stores all incoming data
forever and is never cleaned. Eventually, it will pile up too much
memory and is thus of limited use.

This closes #3129.
This closes #3120 (left over).

@asfgit asfgit closed this in 63a6af3 Jan 20, 2017

joseprupi added a commit to joseprupi/flink that referenced this pull request Feb 12, 2017

[FLINK-5507] [queryable state] Remove list variant of asQueryableState
The queryable state "sink" using ListState stores all incoming data
forever and is never cleaned. Eventually, it will pile up too much
memory and is thus of limited use.

This closes apache#3129.
This closes apache#3120 (left over).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment