New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-5699] [savepoints] Check target dir when cancelling with savepoint #3263

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@uce
Contributor

uce commented Feb 3, 2017

When cancelling a job with a savepoint and no savepoint directory is configured, triggering the savepoint fails with an NPE. This is then returned to the user as the root cause.

Instead of simply forwarding the argument (which is possibly null), we check it for null and return a IllegalStateException with a meaningful message.

[FLINK-5699] [savepoints] Check target dir when cancelling with savep…
…oint

Problem: when cancelling a job with a savepoint and no savepoint directory
is configured, triggering the savepoint fails with an NPE. This is then
returned to the user as the root cause.

Solution: Instead of simply forwarding the argument (which is possibly
null), we check it for null and return a IllegalStateException with
a meaningful message.
@uce

This comment has been minimized.

Show comment
Hide comment
@uce

uce Feb 7, 2017

Contributor

Build failures are unrelated in change is self-contained. Merging this to master and release-1.2.

Contributor

uce commented Feb 7, 2017

Build failures are unrelated in change is self-contained. Merging this to master and release-1.2.

@asfgit asfgit closed this in b452c8b Feb 7, 2017

asfgit pushed a commit that referenced this pull request Feb 7, 2017

[FLINK-5699] [savepoints] Check target dir when cancelling with savep…
…oint

Problem: when cancelling a job with a savepoint and no savepoint directory
is configured, triggering the savepoint fails with an NPE. This is then
returned to the user as the root cause.

Solution: Instead of simply forwarding the argument (which is possibly
null), we check it for null and return a IllegalStateException with
a meaningful message.

This closes #3263.

joseprupi added a commit to joseprupi/flink that referenced this pull request Feb 12, 2017

[FLINK-5699] [savepoints] Check target dir when cancelling with savep…
…oint

Problem: when cancelling a job with a savepoint and no savepoint directory
is configured, triggering the savepoint fails with an NPE. This is then
returned to the user as the root cause.

Solution: Instead of simply forwarding the argument (which is possibly
null), we check it for null and return a IllegalStateException with
a meaningful message.

This closes apache#3263.

@uce uce deleted the uce:5699-cancel_with_savepoint_directory branch Feb 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment