New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-5710] Add ProcTime() function to indicate StreamSQL #3302

Closed
wants to merge 103 commits into
base: master
from

Conversation

Projects
None yet
@ghost

ghost commented Feb 14, 2017

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed
@fhueske

This comment has been minimized.

Show comment
Hide comment
@fhueske

fhueske Feb 14, 2017

Contributor

Thanks for reopening the PR!
I made a few comments on #3271 before and after it was closed that should be addressed.

Thanks, Fabian

Contributor

fhueske commented Feb 14, 2017

Thanks for reopening the PR!
I made a few comments on #3271 before and after it was closed that should be addressed.

Thanks, Fabian

godfreyhe and others added some commits Jan 12, 2017

[FLINK-5553] [network] keep the original throwable in PartitionReques…
…tClientHandler

This way, when checking for a previous error in any input channel, we can throw
a meaningful exception instead of the inspecific
IllegalStateException("There has been an error in the channel.") before.

Note that the original throwable (from an existing channel) may or may not(!)
have been printed by the InputGate yet. Any new input channel, however, did not
get the Throwable and must fail through the (now enhanced) fallback mechanism.

This closes #3299
[FLINK-2908] [web frontend] Redraw web plan when browser resized
Redraw the job plan visual graph when the browser width is increased.

This closes #3251
[FLINK-5745] [runtime] Extract ExecutorThreadFactory#FatalExitExcepti…
…onHandler

Make it a top-level class so that it can be re-used.
[FLINK-5745] [network] Set uncaught exception handler for Netty threads
This sets a JVM-terminating handler that logs errors from uncaught exceptions
and terminates the process so that critical exceptions are not accidentally
lost and leave the system running in an inconsistent state.

This closes #3293.
[FLINK-5800] [checkpointing] Create CheckpointSteamFactory only once …
…per operator

Previously, the factory was created once per checkpoint, and its repeated initialization logic
(like ensuring existence of base paths) caused heavy load on some filesystems at very large scale.

This closes #3312
[FLINK-5771] [core] Fix multi-char delimiter detection in DelimitedIn…
…putFormat.

- Add a test case to validate correct delimiter detection.
- Remove a couple of try-catch blocks from existing tests.

This closes #3316.
[hotfix] [tests] Stabilize FastFailuresITCase
The test triggers 200 immediate failures and recoveries. The restart strategy allowed 200 restarts.

It may happen that another failure occurs as during the execution, in which case the restart attempts are not
sufficient.
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 22, 2017

I managed to merge the changes from PR #3370 into my branch after rebase, and the test works. I will push the code later today. sorry if I am a little latent, but I am travelling and connectivity is sometimes a problem.

ghost commented Feb 22, 2017

I managed to merge the changes from PR #3370 into my branch after rebase, and the test works. I will push the code later today. sorry if I am a little latent, but I am travelling and connectivity is sometimes a problem.

@fhueske

This comment has been minimized.

Show comment
Hide comment
@fhueske

fhueske Feb 22, 2017

Contributor

That would be great @huawei-flink! There are a few contributions waiting for this addition.
Thank you!

Contributor

fhueske commented Feb 22, 2017

That would be great @huawei-flink! There are a few contributions waiting for this addition.
Thank you!

@fhueske

This comment has been minimized.

Show comment
Hide comment
@fhueske

fhueske Feb 22, 2017

Contributor

Hi, it looks like something went wrong when updating the PR.
Can you rebase your changes on the latest master?

Thanks

Contributor

fhueske commented Feb 22, 2017

Hi, it looks like something went wrong when updating the PR.
Can you rebase your changes on the latest master?

Thanks

@StephanEwen

This comment has been minimized.

Show comment
Hide comment
@StephanEwen

StephanEwen Feb 22, 2017

Contributor

Should we make flushOnCheckpoint true by default?

Contributor

StephanEwen commented on 646490c Feb 22, 2017

Should we make flushOnCheckpoint true by default?

This comment has been minimized.

Show comment
Hide comment
@tzulitai

tzulitai Feb 23, 2017

Contributor

@StephanEwen Yes. We discussed that in https://issues.apache.org/jira/browse/FLINK-5728 with some other aspects regarding the setFlushOnCheckpoint and setLogFailuresOnly methods, so it was kept as a separate issue.

Contributor

tzulitai replied Feb 23, 2017

@StephanEwen Yes. We discussed that in https://issues.apache.org/jira/browse/FLINK-5728 with some other aspects regarding the setFlushOnCheckpoint and setLogFailuresOnly methods, so it was kept as a separate issue.

stefanobortoli and others added some commits Feb 1, 2017

Stefano Bortoli
Merge branch 'FLINK-5710' of https://github.com/huawei-flink/flink.git
into FLINK-5710

Conflicts:
	flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
	flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ProcTimeCallGen.scala
	flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala
	flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/TemporalTypesTest.scala
Stefano Bortoli
Merge branch 'FLINK-5710' of https://github.com/huawei-flink/flink.git
into FLINK-5710

Conflicts:
	flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
	flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ProcTimeCallGen.scala
	flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala
	flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/TemporalTypesTest.scala
@fhueske

This comment has been minimized.

Show comment
Hide comment
@fhueske

fhueske Feb 24, 2017

Contributor

Hi @huawei-flink,
as I said before, there are a few contributions waiting for this patch.
I decided to move one and merge PR #3370.

Thanks a again for working on this and sorry for the inconvenience,
Fabian

Contributor

fhueske commented Feb 24, 2017

Hi @huawei-flink,
as I said before, there are a few contributions waiting for this patch.
I decided to move one and merge PR #3370.

Thanks a again for working on this and sorry for the inconvenience,
Fabian

@asfgit asfgit closed this in a755de2 Feb 24, 2017

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 27, 2017

@fhueske no problem, I understand. It was bad timing, as I was on the run for more than two weeks, with little time to follow this. We'll contribute on other issues.

ghost commented Feb 27, 2017

@fhueske no problem, I understand. It was bad timing, as I was on the run for more than two weeks, with little time to follow this. We'll contribute on other issues.

@fhueske

This comment has been minimized.

Show comment
Hide comment
@fhueske

fhueske Feb 27, 2017

Contributor

Thanks @huawei-flink
Looking forward to your contributions!

Contributor

fhueske commented Feb 27, 2017

Thanks @huawei-flink
Looking forward to your contributions!

heytitle added a commit to heytitle/flink that referenced this pull request Apr 16, 2017

hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment