Skip to content

[FLINK-6040] [table] DataStreamUserDefinedFunctionITCase occasionally fails#3530

Closed
zhuoluoy wants to merge 2 commits into
apache:masterfrom
zhuoluoy:flink-6040
Closed

[FLINK-6040] [table] DataStreamUserDefinedFunctionITCase occasionally fails#3530
zhuoluoy wants to merge 2 commits into
apache:masterfrom
zhuoluoy:flink-6040

Conversation

@zhuoluoy

Copy link
Copy Markdown
Contributor

Type: Bug
Priority: Major
Components: table, test
Problem Definition: DataStreamUserDefinedFunctionITCase occasionally fails
Design:
Three test cases in DataStreamUserDefinedFunctionITCase forgot to call the method StreamITCase.clear method. This will cause the case occasionally fails. Because the result of one case may affect another sometimes. The patch the is simply adding the missing methods.
Impact Analysis:
Only the tests. No impacts on the core code.
Test:
Tested DataStreamUserDefinedFunctionITCase locally.

@KurtYoung KurtYoung left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @clarkyzl , thanks for the fix

def testUserDefinedTableFunctionWithParameter(): Unit = {
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = TableEnvironment.getTableEnvironment(env)
StreamITCase.clear

@KurtYoung KurtYoung Mar 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move these to case setup?

@KurtYoung

Copy link
Copy Markdown
Contributor

looks good, merging

@asfgit asfgit closed this in 6f7d7a0 Mar 15, 2017
p16i pushed a commit to p16i/flink that referenced this pull request Apr 16, 2017
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants