New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6200][SQL] support unbounded event time range window #3649

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@hongyuhong
Contributor

hongyuhong commented Mar 30, 2017

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General

    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed
/**
* A ProcessFunction to support unbounded ROWS window.
* With the ROWS option you define on a physical level how many rows are included in your window frame

This comment has been minimized.

@fhueske

fhueske Mar 30, 2017

Contributor

This line violates the 100 character limit of the Scala code style.
Please run a local build before opening a PR to capture such problems (mvn clean install inside of the ./flink-libraries/flink-table folder is usually sufficient and takes ~5 mins).

@fhueske

fhueske Mar 30, 2017

Contributor

This line violates the 100 character limit of the Scala code style.
Please run a local build before opening a PR to capture such problems (mvn clean install inside of the ./flink-libraries/flink-table folder is usually sufficient and takes ~5 mins).

This comment has been minimized.

@hongyuhong

hongyuhong Mar 31, 2017

Contributor

Thanks for reminding me, i will pay attention next time.

@hongyuhong

hongyuhong Mar 31, 2017

Contributor

Thanks for reminding me, i will pay attention next time.

@fhueske

This comment has been minimized.

Show comment
Hide comment
@fhueske

fhueske Mar 30, 2017

Contributor

Hi @hongyuhong, the PR looks very good (except for the style error).
I'll fix that and merge the PR.

Thanks, Fabian

Contributor

fhueske commented Mar 30, 2017

Hi @hongyuhong, the PR looks very good (except for the style error).
I'll fix that and merge the PR.

Thanks, Fabian

@asfgit asfgit closed this in 44f9c76 Mar 30, 2017

heytitle added a commit to heytitle/flink that referenced this pull request Apr 16, 2017

hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment