Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[FLINK-6011] Support TUMBLE, HOP, SESSION window in streaming SQL. #3665
Conversation
|
Thanks for the PR @haohui! |
|
So we finally got those supported by Calcite 1.12?Really excited to see those features supported in flinkSQL. Thanks @haohui. |
| ProcTimeExtractor | ||
| ProcTimeExtractor, | ||
| SqlStdOperatorTable.TUMBLE, | ||
| SqlStdOperatorTable.TUMBLE_START, |
This comment has been minimized.
This comment has been minimized.
twalthr
Apr 4, 2017
Contributor
Do we already support the START/END functions? We should let them unsupported until they are implemented and tested.
|
|
||
| private[flink] val INSTANCE = new LogicalWindowAggregateRule | ||
| protected def getOperandAsLong(idx: Int): Long = | ||
| unwrapLiteral[BigDecimal](call.getOperands.get(idx)).longValue() |
This comment has been minimized.
This comment has been minimized.
twalthr
Apr 4, 2017
Contributor
Does Calcite ensure that operands can only be literals, no input reference?
This comment has been minimized.
This comment has been minimized.
haohui
Apr 5, 2017
Author
I just tried out Calcite did not stop you from passing something like a {{RexCall}}. So yes, it can be dynamic.
One question: whether Flink actually supports GroupWindow that has a dynamic size? Maybe I'm wrong but it does not seem so.
If the answer is no maybe we should check that whether it is a RexLiteral?
This comment has been minimized.
This comment has been minimized.
fhueske
Apr 5, 2017
Contributor
Flink does only support windows with fixed configuration (SESSION windows have variable length, but the gap parameter is fixed). I'm also not sure if that would make sense. It's quite hard to reason about the behavior of a window with variable parameters, IMO.
This comment has been minimized.
This comment has been minimized.
haohui
Apr 5, 2017
Author
Agree. 97d1a45 will throw an TableException if the configuration is not fixed.
|
Thanks for the update @haohui! |
…ns in SQL queries on streams. This closes apache#3665.
…ons in SQL queries on streams. This closes apache#3665.
…ons in SQL queries on streams. This closes apache#3665.
haohui commentedApr 3, 2017
This PR adds supports for the
TUMBLE,HOP, andSESSIONwindows in Flink.The work of supporting WindowStart and WindowEnd expressions will be deferred to FLINK-6012.