New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6330] [docs] Add basic Docker, K8s docs #3751

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@patricklucas
Contributor

patricklucas commented Apr 21, 2017

I may do some more work on these before 1.2.2/1.3, but I'd like to at least get this basic information into master.

@StephanEwen

This comment has been minimized.

Show comment
Hide comment
@StephanEwen

StephanEwen Apr 25, 2017

Contributor

Great, thanks!

Merging this...

Contributor

StephanEwen commented Apr 25, 2017

Great, thanks!

Merging this...

StephanEwen added a commit to StephanEwen/incubator-flink that referenced this pull request Apr 25, 2017

@StephanEwen

This comment has been minimized.

Show comment
Hide comment
@StephanEwen

StephanEwen Apr 25, 2017

Contributor

Sorry, taking a step back.

It seems that https://hub.docker.com/_/flink/ is not yet available. Should we postpone this merge until it is available?

Contributor

StephanEwen commented Apr 25, 2017

Sorry, taking a step back.

It seems that https://hub.docker.com/_/flink/ is not yet available. Should we postpone this merge until it is available?

@patricklucas

This comment has been minimized.

Show comment
Hide comment
@patricklucas

patricklucas Apr 25, 2017

Contributor

It will be available before the next release, though I noticed just yesterday that it seems we build the official 1.2 docs (erroneously?) from a development branch instead of the actual tagged release.

I'm about ready to submit the PR to get the official images created, but it's fine if you want to wait.

Contributor

patricklucas commented Apr 25, 2017

It will be available before the next release, though I noticed just yesterday that it seems we build the official 1.2 docs (erroneously?) from a development branch instead of the actual tagged release.

I'm about ready to submit the PR to get the official images created, but it's fine if you want to wait.

@greghogan

This comment has been minimized.

Show comment
Hide comment
@greghogan

greghogan May 9, 2017

Contributor

@patricklucas when will the link be available? It would be great to have this merged for 1.3.

Contributor

greghogan commented May 9, 2017

@patricklucas when will the link be available? It would be great to have this merged for 1.3.

@patricklucas

This comment has been minimized.

Show comment
Hide comment
@patricklucas

patricklucas May 9, 2017

Contributor

@greghogan we're waiting patiently for @tianon to complete his review of docker-library/official-images#2895. :)

As far as I know, we've done everything we need to do to get the images published. We have a +1 from @yosifkit, but two reviews are required.

Contributor

patricklucas commented May 9, 2017

@greghogan we're waiting patiently for @tianon to complete his review of docker-library/official-images#2895. :)

As far as I know, we've done everything we need to do to get the images published. We have a +1 from @yosifkit, but two reviews are required.

@patricklucas

This comment has been minimized.

Show comment
Hide comment
@patricklucas

patricklucas May 10, 2017

Contributor

The link is available now!

Contributor

patricklucas commented May 10, 2017

The link is available now!

@@ -77,3 +77,6 @@
.highlight .vg { color: #008080 } /* Name.Variable.Global */
.highlight .vi { color: #008080 } /* Name.Variable.Instance */
.highlight .il { color: #009999 } /* Literal.Number.Integer.Long */
/* Missing YAML styles */
.highlight .l-Scalar-Plain { color: #008080 }

This comment has been minimized.

@greghogan

greghogan May 10, 2017

Contributor

What is this line doing? Why does YAML equate to l-Scalar-Plain? Is YAML unknown to the highlighter?

@greghogan

greghogan May 10, 2017

Contributor

What is this line doing? Why does YAML equate to l-Scalar-Plain? Is YAML unknown to the highlighter?

This comment has been minimized.

@patricklucas

patricklucas May 10, 2017

Contributor

Yeah, the highlighter we use doesn't have any built-in styling for YAML. I had to search around quite a bit for context and came up mostly dry.

Moreover, the actual tokenizer it uses only emits two token types, l-Scalar-Plain and p-Indicator. (You can see this in action by inspecting the HTML here)

This change applies the color I found most applicable from the existing highlighting rules and applies it to l-Scalar-Plain to make it at least slightly more interesting than black-on-white.

@patricklucas

patricklucas May 10, 2017

Contributor

Yeah, the highlighter we use doesn't have any built-in styling for YAML. I had to search around quite a bit for context and came up mostly dry.

Moreover, the actual tokenizer it uses only emits two token types, l-Scalar-Plain and p-Indicator. (You can see this in action by inspecting the HTML here)

This change applies the color I found most applicable from the existing highlighting rules and applies it to l-Scalar-Plain to make it at least slightly more interesting than black-on-white.

This comment has been minimized.

@greghogan

greghogan May 10, 2017

Contributor

I think we should merge this PR without this change and look at fixing this in another ticket. There are other highlighters with true YAML support.

@greghogan

greghogan May 10, 2017

Contributor

I think we should merge this PR without this change and look at fixing this in another ticket. There are other highlighters with true YAML support.

@asfgit asfgit closed this in 91f3765 May 10, 2017

asfgit pushed a commit that referenced this pull request May 10, 2017

asfgit pushed a commit that referenced this pull request May 10, 2017

StefanRRichter added a commit to StefanRRichter/flink that referenced this pull request May 11, 2017

StefanRRichter added a commit to StefanRRichter/flink that referenced this pull request May 12, 2017

StefanRRichter added a commit to StefanRRichter/flink that referenced this pull request May 12, 2017

fanyon pushed a commit to fanyon/flink that referenced this pull request May 15, 2017

jinglining pushed a commit to jinglining/flink that referenced this pull request May 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment