Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
FLINK-6284 Incorrect sorting of completed checkpoints in ZooKeeperCompletedCheckpointStore #3881
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
Making use of the Zookeeper's getChildren() API directly so that it just creates a list in the sequence order. If we go with the ZKPaths API then we need to do some sorting by converting the List to List.
Thanks for your contribution @ramkrish86. But I think the PR does not fix the underlying problem because it relies on the fact that
ZooKeeper#getChildren returns the children in the right order, which it does not guarantee if I'm not mistaken.
Thanks for your contribution @ramkrish86. I still think that this PR does not sufficiently solve the problem. I guess we should either use the czxid for sorting or adapt the path generation to make it sortable.
I won't be available for next 2 to 3 hours. So feel free to decide based on your convenience in case you need to make the RC candidate for 1.3 release. I am sorry that I could not make an initial commit that took care of things properly, should have been more careful. Thanks for the opportunity.