From d952d6cc17fc683ebd1c93e1c044f79428a1b980 Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Mon, 15 May 2017 09:35:36 -0400 Subject: [PATCH 1/4] [FLINK-6582] [docs] Project from maven archetype is not buildable by default The pom.xml for flink-quickstart-java and flink-quickstart-scala must specify scala.version and scala.binary.version. --- .../main/resources/archetype-resources/pom.xml | 15 +++++++-------- .../main/resources/archetype-resources/pom.xml | 6 ++++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml index 9991d2c75efe2..060a7b2a0fe59 100644 --- a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml +++ b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml @@ -19,7 +19,7 @@ under the License. 4.0.0 - + ${groupId} ${artifactId} ${version} @@ -33,6 +33,8 @@ under the License. 1.4-SNAPSHOT 1.7.7 1.2.17 + 2.11.11 + 2.11 @@ -48,9 +50,9 @@ under the License. - + - diff --git a/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml b/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml index 2139c6bc336d1..0cad55348b6f7 100644 --- a/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml +++ b/flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml @@ -48,10 +48,12 @@ under the License. 1.4-SNAPSHOT 1.7.7 1.2.17 + 2.11.11 + 2.11 From e53031ac722831e47eb2a98b37be8bbf8e0fce8b Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Mon, 15 May 2017 10:47:04 -0400 Subject: [PATCH 2/4] Inherit scala.binary.version from Flink project --- .../resources/archetype-resources/pom.xml | 33 ++++++++--------- .../resources/archetype-resources/pom.xml | 37 +++++++++---------- flink-quickstart/pom.xml | 15 ++++++++ 3 files changed, 49 insertions(+), 36 deletions(-) diff --git a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml index 060a7b2a0fe59..ce6c64c15220d 100644 --- a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml +++ b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml @@ -33,8 +33,7 @@ under the License. 1.4-SNAPSHOT 1.7.7 1.2.17 - 2.11.11 - 2.11 + ${scala.binary.version} @@ -84,12 +83,12 @@ under the License. org.apache.flink - flink-streaming-java_${scala.binary.version} + flink-streaming-java_\${scala.binary.version} ${flink.version} org.apache.flink - flink-clients_${scala.binary.version} + flink-clients_\${scala.binary.version} ${flink.version} @@ -125,13 +124,13 @@ under the License. org.apache.flink - flink-streaming-java_${scala.binary.version} + flink-streaming-java_\${scala.binary.version} ${flink.version} provided org.apache.flink - flink-clients_${scala.binary.version} + flink-clients_\${scala.binary.version} ${flink.version} provided @@ -202,20 +201,20 @@ under the License. org.apache.flink:flink-shaded-curator-recipes org.apache.flink:flink-core org.apache.flink:flink-java - org.apache.flink:flink-scala_${scala.binary.version} - org.apache.flink:flink-runtime_${scala.binary.version} - org.apache.flink:flink-optimizer_${scala.binary.version} - org.apache.flink:flink-clients_${scala.binary.version} - org.apache.flink:flink-avro_${scala.binary.version} - org.apache.flink:flink-examples-batch_${scala.binary.version} - org.apache.flink:flink-examples-streaming_${scala.binary.version} - org.apache.flink:flink-streaming-java_${scala.binary.version} - org.apache.flink:flink-streaming-scala_${scala.binary.version} - org.apache.flink:flink-scala-shell_${scala.binary.version} + org.apache.flink:flink-scala_\${scala.binary.version} + org.apache.flink:flink-runtime_\${scala.binary.version} + org.apache.flink:flink-optimizer_\${scala.binary.version} + org.apache.flink:flink-clients_\${scala.binary.version} + org.apache.flink:flink-avro_\${scala.binary.version} + org.apache.flink:flink-examples-batch_\${scala.binary.version} + org.apache.flink:flink-examples-streaming_\${scala.binary.version} + org.apache.flink:flink-streaming-java_\${scala.binary.version} + org.apache.flink:flink-streaming-scala_\${scala.binary.version} + org.apache.flink:flink-scala-shell_\${scala.binary.version} org.apache.flink:flink-python org.apache.flink:flink-metrics-core org.apache.flink:flink-metrics-jmx - org.apache.flink:flink-statebackend-rocksdb_${scala.binary.version} + org.apache.flink:flink-statebackend-rocksdb_\${scala.binary.version} org.apache.flink - flink-scala_${scala.binary.version} + flink-scala_\${scala.binary.version} ${flink.version} org.apache.flink - flink-streaming-scala_${scala.binary.version} + flink-streaming-scala_\${scala.binary.version} ${flink.version} org.apache.flink - flink-clients_${scala.binary.version} + flink-clients_\${scala.binary.version} ${flink.version} @@ -118,19 +117,19 @@ under the License. org.apache.flink - flink-scala_${scala.binary.version} + flink-scala_\${scala.binary.version} ${flink.version} provided org.apache.flink - flink-streaming-scala_${scala.binary.version} + flink-streaming-scala_\${scala.binary.version} ${flink.version} provided org.apache.flink - flink-clients_${scala.binary.version} + flink-clients_\${scala.binary.version} ${flink.version} provided @@ -204,20 +203,20 @@ under the License. org.apache.flink:flink-shaded-curator-recipes org.apache.flink:flink-core org.apache.flink:flink-java - org.apache.flink:flink-scala_${scala.binary.version} - org.apache.flink:flink-runtime_${scala.binary.version} - org.apache.flink:flink-optimizer_${scala.binary.version} - org.apache.flink:flink-clients_${scala.binary.version} - org.apache.flink:flink-avro_${scala.binary.version} - org.apache.flink:flink-examples-batch_${scala.binary.version} - org.apache.flink:flink-examples-streaming_${scala.binary.version} - org.apache.flink:flink-streaming-java_${scala.binary.version} - org.apache.flink:flink-streaming-scala_${scala.binary.version} - org.apache.flink:flink-scala-shell_${scala.binary.version} + org.apache.flink:flink-scala_\${scala.binary.version} + org.apache.flink:flink-runtime_\${scala.binary.version} + org.apache.flink:flink-optimizer_\${scala.binary.version} + org.apache.flink:flink-clients_\${scala.binary.version} + org.apache.flink:flink-avro_\${scala.binary.version} + org.apache.flink:flink-examples-batch_\${scala.binary.version} + org.apache.flink:flink-examples-streaming_\${scala.binary.version} + org.apache.flink:flink-streaming-java_\${scala.binary.version} + org.apache.flink:flink-streaming-scala_\${scala.binary.version} + org.apache.flink:flink-scala-shell_\${scala.binary.version} org.apache.flink:flink-python org.apache.flink:flink-metrics-core org.apache.flink:flink-metrics-jmx - org.apache.flink:flink-statebackend-rocksdb_${scala.binary.version} + org.apache.flink:flink-statebackend-rocksdb_\${scala.binary.version} + + org.apache.maven.plugins + maven-resources-plugin + + \ + + + + + src/main/resources/archetype-resources + true + + From f638c44433ac0699f95a011c0b4c3900727a3888 Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Thu, 18 May 2017 14:16:12 -0400 Subject: [PATCH 3/4] Fix path for filtering archetype-resources --- flink-quickstart/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/flink-quickstart/pom.xml b/flink-quickstart/pom.xml index fcdb172fb7398..9e97e37264bb5 100644 --- a/flink-quickstart/pom.xml +++ b/flink-quickstart/pom.xml @@ -92,7 +92,7 @@ under the License. - src/main/resources/archetype-resources + src/main/resources true From 412cf808f7edc6ee5e852fb782c71b075777fd4a Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Thu, 18 May 2017 15:08:37 -0400 Subject: [PATCH 4/4] Use non-standard delimiter rather than escaping '${}' delimiter. --- .../resources/archetype-resources/pom.xml | 32 ++++++++--------- .../resources/archetype-resources/pom.xml | 36 +++++++++---------- flink-quickstart/pom.xml | 7 ++-- 3 files changed, 39 insertions(+), 36 deletions(-) diff --git a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml index ce6c64c15220d..44c56b971c4c0 100644 --- a/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml +++ b/flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml @@ -33,7 +33,7 @@ under the License. 1.4-SNAPSHOT 1.7.7 1.2.17 - ${scala.binary.version} + @scala.binary.version@ @@ -83,12 +83,12 @@ under the License. org.apache.flink - flink-streaming-java_\${scala.binary.version} + flink-streaming-java_${scala.binary.version} ${flink.version} org.apache.flink - flink-clients_\${scala.binary.version} + flink-clients_${scala.binary.version} ${flink.version} @@ -124,13 +124,13 @@ under the License. org.apache.flink - flink-streaming-java_\${scala.binary.version} + flink-streaming-java_${scala.binary.version} ${flink.version} provided org.apache.flink - flink-clients_\${scala.binary.version} + flink-clients_${scala.binary.version} ${flink.version} provided @@ -201,20 +201,20 @@ under the License. org.apache.flink:flink-shaded-curator-recipes org.apache.flink:flink-core org.apache.flink:flink-java - org.apache.flink:flink-scala_\${scala.binary.version} - org.apache.flink:flink-runtime_\${scala.binary.version} - org.apache.flink:flink-optimizer_\${scala.binary.version} - org.apache.flink:flink-clients_\${scala.binary.version} - org.apache.flink:flink-avro_\${scala.binary.version} - org.apache.flink:flink-examples-batch_\${scala.binary.version} - org.apache.flink:flink-examples-streaming_\${scala.binary.version} - org.apache.flink:flink-streaming-java_\${scala.binary.version} - org.apache.flink:flink-streaming-scala_\${scala.binary.version} - org.apache.flink:flink-scala-shell_\${scala.binary.version} + org.apache.flink:flink-scala_${scala.binary.version} + org.apache.flink:flink-runtime_${scala.binary.version} + org.apache.flink:flink-optimizer_${scala.binary.version} + org.apache.flink:flink-clients_${scala.binary.version} + org.apache.flink:flink-avro_${scala.binary.version} + org.apache.flink:flink-examples-batch_${scala.binary.version} + org.apache.flink:flink-examples-streaming_${scala.binary.version} + org.apache.flink:flink-streaming-java_${scala.binary.version} + org.apache.flink:flink-streaming-scala_${scala.binary.version} + org.apache.flink:flink-scala-shell_${scala.binary.version} org.apache.flink:flink-python org.apache.flink:flink-metrics-core org.apache.flink:flink-metrics-jmx - org.apache.flink:flink-statebackend-rocksdb_\${scala.binary.version} + org.apache.flink:flink-statebackend-rocksdb_${scala.binary.version} org.apache.flink - flink-scala_\${scala.binary.version} + flink-scala_${scala.binary.version} ${flink.version} org.apache.flink - flink-streaming-scala_\${scala.binary.version} + flink-streaming-scala_${scala.binary.version} ${flink.version} org.apache.flink - flink-clients_\${scala.binary.version} + flink-clients_${scala.binary.version} ${flink.version} @@ -117,19 +117,19 @@ under the License. org.apache.flink - flink-scala_\${scala.binary.version} + flink-scala_${scala.binary.version} ${flink.version} provided org.apache.flink - flink-streaming-scala_\${scala.binary.version} + flink-streaming-scala_${scala.binary.version} ${flink.version} provided org.apache.flink - flink-clients_\${scala.binary.version} + flink-clients_${scala.binary.version} ${flink.version} provided @@ -203,20 +203,20 @@ under the License. org.apache.flink:flink-shaded-curator-recipes org.apache.flink:flink-core org.apache.flink:flink-java - org.apache.flink:flink-scala_\${scala.binary.version} - org.apache.flink:flink-runtime_\${scala.binary.version} - org.apache.flink:flink-optimizer_\${scala.binary.version} - org.apache.flink:flink-clients_\${scala.binary.version} - org.apache.flink:flink-avro_\${scala.binary.version} - org.apache.flink:flink-examples-batch_\${scala.binary.version} - org.apache.flink:flink-examples-streaming_\${scala.binary.version} - org.apache.flink:flink-streaming-java_\${scala.binary.version} - org.apache.flink:flink-streaming-scala_\${scala.binary.version} - org.apache.flink:flink-scala-shell_\${scala.binary.version} + org.apache.flink:flink-scala_${scala.binary.version} + org.apache.flink:flink-runtime_${scala.binary.version} + org.apache.flink:flink-optimizer_${scala.binary.version} + org.apache.flink:flink-clients_${scala.binary.version} + org.apache.flink:flink-avro_${scala.binary.version} + org.apache.flink:flink-examples-batch_${scala.binary.version} + org.apache.flink:flink-examples-streaming_${scala.binary.version} + org.apache.flink:flink-streaming-java_${scala.binary.version} + org.apache.flink:flink-streaming-scala_${scala.binary.version} + org.apache.flink:flink-scala-shell_${scala.binary.version} org.apache.flink:flink-python org.apache.flink:flink-metrics-core org.apache.flink:flink-metrics-jmx - org.apache.flink:flink-statebackend-rocksdb_\${scala.binary.version} + org.apache.flink:flink-statebackend-rocksdb_${scala.binary.version} + org.apache.maven.plugins maven-resources-plugin - \ + false + + @ +