New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7178] [metrics] Do not create separate shaded jars #4326

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
4 participants
@zentol
Contributor

zentol commented Jul 13, 2017

No description provided.

@StephanEwen

This comment has been minimized.

Show comment
Hide comment
@StephanEwen

StephanEwen Jul 14, 2017

Contributor

Looks good.

I would suggest to add a description to the PR (be it only a copy of the JIRA text). Nice support for the reviewers to get context without manually navigating to JIRA to learn about the bug.

Contributor

StephanEwen commented Jul 14, 2017

Looks good.

I would suggest to add a description to the PR (be it only a copy of the JIRA text). Nice support for the reviewers to get context without manually navigating to JIRA to learn about the bug.

@aljoscha

This comment has been minimized.

Show comment
Hide comment
@aljoscha

aljoscha Jul 17, 2017

Contributor

@zentol What's the plan for merging this? (Asking because it's one of the remaining blockers for 1.3.2)

Contributor

aljoscha commented Jul 17, 2017

@zentol What's the plan for merging this? (Asking because it's one of the remaining blockers for 1.3.2)

@zentol

This comment has been minimized.

Show comment
Hide comment
@zentol

zentol Jul 17, 2017

Contributor

@aljoscha The fix is not quite correct since I didn't update the flink-dist assembly files. Just pushed a fix for that though. I can merge it later today. (once my local travis passed for it)

Contributor

zentol commented Jul 17, 2017

@aljoscha The fix is not quite correct since I didn't update the flink-dist assembly files. Just pushed a fix for that though. I can merge it later today. (once my local travis passed for it)

@zentol zentol closed this Jul 18, 2017

@zentol zentol reopened this Jul 18, 2017

@asfgit asfgit merged commit 67fb2f3 into apache:master Jul 18, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@zentol zentol deleted the zentol:7178 branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment