Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-1655] Renamed StreamInvokable to StreamOperator and all its subclasses and tests in a similar fashion. #508

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@akshaydixi
Copy link
Contributor

akshaydixi commented Mar 21, 2015

Changes made are:

  • StreamInvokable -> StreamOperator
  • ChainableInvokable -> ChainableStreamOperator
  • SinkInvokable -> SinkStreamOperator
  • SourceInvokable -> SourceStreamOperator
  • CoFlatMapInvokable -> CoFlatMapStreamOperator
  • CoGroupedReduceInvokable -> CoGroupedReduceStreamOperator
  • CoInvokable -> CoStreamOperator
  • CoMapInvokable -> CoMapStreamOperator
  • CoReduceInvokable -> CoReduceStreamOperator
  • CoWindowInvokable -> CoWindowStreamOperator
  • GroupedWindowBufferInvokable -> GroupedWindowBufferStreamOperator
  • WindowBufferInvokable -> WindowBufferStreamOperator
  • CounterInvokable -> CounterStreamOperator
  • FilterInvokable -> FilterStreamOperator
  • FlatMapInvokable -> FlatMapStreamOperator
  • GroupedFoldInvokable -> GroupedFoldStreamOperator
  • GroupedReduceInvokable -> GroupedReduceStreamOperator
  • MapInvokable -> MapStreamOperator
  • ProjectInvokable -> ProjectStreamOperator
  • StreamFoldInvokable -> FoldStreamOperator
  • StreamReduceInvokable -> ReduceStreamOperator

akshaydixi added some commits Mar 21, 2015

@mbalassi

This comment has been minimized.

Copy link
Contributor

mbalassi commented Mar 22, 2015

Nice, thanks for also updating the minor details. GroupedWindowBufferStreamOperator is a bit long of a name for my taste, but other than LGTM. :)

@gyfora

This comment has been minimized.

Copy link
Contributor

gyfora commented Mar 22, 2015

I personally don't like the sound of all these class names too much. It seems to be too redundant and too long in most cases. I know the ...Invokables weren't so much better either but at least they were short.

Let us think about this for a little before making these changes.

@gyfora

This comment has been minimized.

Copy link
Contributor

gyfora commented Apr 13, 2015

Hey
Sorry I made a major refactoring today, and I also did the renaming with much shorter names.

@akshaydixi

This comment has been minimized.

Copy link
Contributor Author

akshaydixi commented Apr 14, 2015

Ok. So should I delete this branch then?

@gyfora

This comment has been minimized.

Copy link
Contributor

gyfora commented Apr 14, 2015

yes please

@akshaydixi akshaydixi closed this Apr 15, 2015

@akshaydixi akshaydixi deleted the akshaydixi:FLINK-1655 branch Apr 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.