[FLINK-8335] [hbase] Upgrade hbase connector dependency to 1.4.3 #5488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greghogan
reviewed
Feb 15, 2018
flink-connectors/flink-hbase/pom.xml
Outdated
|
|
||
| <properties> | ||
| <hbase.version>1.3.1</hbase.version> | ||
| <hbase.version>1.4.0</hbase.version> |
rice668
force-pushed
the
FLINK-8335-hbase-upgrade
branch
from
7f156d0 to
b01b494
Compare
Contributor
|
Should be good after 1.4.1 is filled in |
Contributor
|
Just to be safe, could you paste the diff in the dependency tree of the Always good to know which additional dependencies one pulls in through such a version upgrade. |
rice668
changed the title
Author
|
I paste the the 1.3.1 and 1.4.1 I watched the difference between the two dependencies. But I would hope @StephanEwen can see the difference as well by this tool (https://www.diffnow.com/). Thanks. 1.3.1 1.4.1 |
Author
|
Sup ? |
Contributor
|
Thanks! The dependency tree is huge, and a good amount is for |
Contributor
|
Okay, seems we cannot exclude hbase server (hell, hadoop projects really mess up their dependencies). Can you try to exclude some of the dependencies, like jersey, jruby, tomcat, etc? |
Author
|
Yeah. Actually, We had those dependencies when 1.3.1. We should exclude them at that time. But we did not. |
Author
|
@StephanEwen I would ask , what way you used for judging exclude those dependencies (jersey, jruby, tomcat) ? I used |
Contributor
|
I haven't looked at the changelog but HBase 1.4.2 was released a few weeks ago. |
Contributor
|
@zhangminglei You are right, the dependencies should have been excluded back then. But better to fix later than never ;-) For the dependencies to exclude, it is hard to find that out. I was mainly guessing, to be honest, thinking that an HBase client should not need a REST PI framework (jersey) or J2EE server (tomcat) as a dependency. |
Author
|
Thanks you very much @StephanEwen and @greghogan . When I am free, I will take a look and verify on hbase 1.4.2. |
rice668
force-pushed
the
FLINK-8335-hbase-upgrade
branch
from
b01b494 to
daa9b39
Compare
Author
|
I put this upgrade dependency tree here for a reference. |
rice668
changed the title
Author
|
Hi, @StephanEwen and @greghogan I think this patch is ready for having another review now. Could you please ? Thank you. And the CI error does not relevant to this issue itself. |
rice668
force-pushed
the
FLINK-8335-hbase-upgrade
branch
from
daa9b39 to
0db7c29
Compare
Author
|
Sup ? |
Contributor
|
All right, trying to merge this for 1.6 |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Apr 17, 2018
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Apr 17, 2018
Author
|
Okay 👍 |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
Apr 22, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Upgrade hbase connector dependency to 1.4.3
Brief change log
Update pom.xml file.
Verifying this change
Let us wait for the CI server test whether all passed.