[FLINK-10229] [sql-client] Support listing of views #6631

yanghua · 2018-08-29T15:23:05Z

What is the purpose of the change

This pull request support listing of views

Brief change log

Support sql SHOW VIEWS

Verifying this change

This change added tests and can be verified as follows:

SqlCommandParserTest#testCommands to test command parsing
LocalExecutorITCase#testListViews

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

yanghua · 2018-08-30T01:36:52Z

cc @fhueske and @twalthr

yanghua · 2018-08-30T14:58:07Z

@walterddr and @hequn8128 Can you help me to review this PR? thanks.

hequn8128 · 2018-08-31T01:06:56Z

@yanghua Thanks for your PR. I will take a look this weekend. :-)

hequn8128

@yanghua I left some suggestions, please take a look. Suggestions mainly include:

Correct documents about SHOW VIEWS.
Sort view names in alphabetical order.
Add list views in Executor and refactor test cases.

Best, Hequn

hequn8128 · 2018-09-02T10:19:45Z

docs/dev/table/sqlClient.md

@@ -503,6 +503,12 @@ Views created within a CLI session can also be removed again using the `DROP VIE
 DROP VIEW MyNewView
 {% endhighlight %}

+Views created within a CLI session can also be shown again using the `SHOW VIEWS` statement:


Views created in a session environment file can also be listed, so change the description to:
Displays all of the views in the current session using the `SHOW VIEWS` statement:

hequn8128 · 2018-09-02T10:19:49Z

flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java

@@ -332,6 +336,17 @@ private void callShowTables() {
 		terminal.flush();
 	}

+	private void callShowViews() {
+		final Set<String> views = context.getViews().keySet();


Get views from Executor like listTables so that to provide listViews for external systems and gateway mode.

hequn8128 · 2018-09-02T10:19:51Z

flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java

+		if (views.isEmpty()) {
+			terminal.writer().println(CliStrings.messageInfo(CliStrings.MESSAGE_EMPTY).toAnsi());
+		} else {
+			views.forEach((v) -> terminal.writer().println(v));


Would it better to sort views in alphabetical order(also for show functions)? Show tables did in this way as table names stored in a TreeSet in table environment.
What do you think? @twalthr @yanghua

hequn8128 · 2018-09-02T10:19:55Z

...ql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java

+
+		executor.validateSession(session);
+
+		assertEquals(session.getViews().size(), 0);


Use executor to test list views(similar to testListTables and testListUserDefinedFunctions). There are 2 views in the default environment. Executor will merge environments.

yanghua · 2018-09-04T16:01:37Z

@hequn8128 thanks for your suggestion, I have refactored this PR, can you review it again?

yanghua · 2018-09-06T15:29:28Z

@twalthr Would you like to review this PR? thanks~

hequn8128 · 2018-09-07T08:49:26Z

flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala

@@ -587,6 +587,18 @@ abstract class TableEnvironment(val config: TableConfig) {
    rootSchema.getTableNames.asScala.toArray
  }

+  def listViews(): Array[String] = {


I think we can't add this function in TableEnvironment. Reasons are:

table.isInstanceOf[RelTable] is not necessary a View. RelTable can be registered through registerTable().

TableEnvironment currently doesn't support view. It is only supported in SQL-Client now.

As a choice, you can list views directly from the session passed to the listViews(). Also pay attention to the order.

Do you mean that I use the original implementation directly, just move it to the Executor? I used to get from the session, I misunderstood what you mean, I thought it was to refer to the implementation of the listTable method.

hequn8128 · 2018-09-07T08:49:33Z

...ql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java

+
+		final List<String> actualViews = executor.listViews(session);
+
+		final List<String> expectedViews = Arrays.asList(


Add some other views and test the order.

yanghua · 2018-09-08T09:05:39Z

@hequn8128 What about this change?

hequn8128 · 2018-09-10T12:54:39Z

Hi @yanghua , thanks for your update. The PR looks good. +1 to merge from my side.
Best, Hequn

yanghua · 2018-09-11T15:30:25Z

hi @twalthr , hequn helped me to review this PR, does it look good to you?

yanghua · 2018-09-17T12:33:38Z

hi @fhueske can you review this PR? Thanks.

yanghua · 2018-09-26T09:28:01Z

hi @twalthr , hequn has reviewed this PR, can you make a deterministic review?

twalthr · 2018-10-01T14:25:17Z

@yanghua Sorry, for the delay. I will take a look at it soon. I want to think about our general design for views before.

yanghua · 2019-03-12T03:42:51Z

Have fixed some conflicts and rebased this PR. It has stayed for more than half a year, hope for reviewing. cc @twalthr

yanghua · 2020-05-07T03:28:24Z

leaving...

twalthr changed the title ~~[FLINK-10229][SQL CLIENT] Support listing of views~~ [FLINK-10229] [sql-client] Support listing of views Aug 31, 2018

hequn8128 reviewed Sep 2, 2018

View reviewed changes

yanghua force-pushed the FLINK-10229 branch from 1516357 to fddcf3c Compare September 4, 2018 12:05

hequn8128 reviewed Sep 7, 2018

View reviewed changes

yanghua force-pushed the FLINK-10229 branch from fddcf3c to ded3956 Compare September 8, 2018 04:00

yanghua force-pushed the FLINK-10229 branch 4 times, most recently from f878230 to 5d9ba4d Compare March 11, 2019 11:48

[FLINK-10229][Sql Client] Support listing of views

f135b25

yanghua force-pushed the FLINK-10229 branch from 5d9ba4d to f135b25 Compare March 12, 2019 01:24

rmetzger added the component=SQL/Client label Mar 18, 2019

yanghua closed this May 7, 2020

flinkbot added component=TableSQL/Client and removed component=SQL/Client labels Mar 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-10229] [sql-client] Support listing of views #6631

[FLINK-10229] [sql-client] Support listing of views #6631

yanghua commented Aug 29, 2018

yanghua commented Aug 30, 2018

yanghua commented Aug 30, 2018

hequn8128 commented Aug 31, 2018

hequn8128 left a comment •

edited

hequn8128 Sep 2, 2018

hequn8128 Sep 2, 2018

hequn8128 Sep 2, 2018

hequn8128 Sep 2, 2018

yanghua commented Sep 4, 2018

yanghua commented Sep 6, 2018

hequn8128 Sep 7, 2018

yanghua Sep 7, 2018

hequn8128 Sep 7, 2018

yanghua commented Sep 8, 2018

hequn8128 commented Sep 10, 2018

yanghua commented Sep 11, 2018

yanghua commented Sep 17, 2018

yanghua commented Sep 26, 2018

twalthr commented Oct 1, 2018

yanghua commented Mar 12, 2019

yanghua commented May 7, 2020


		executor.validateSession(session);

		assertEquals(session.getViews().size(), 0);


		final List<String> actualViews = executor.listViews(session);

		final List<String> expectedViews = Arrays.asList(

[FLINK-10229] [sql-client] Support listing of views #6631

[FLINK-10229] [sql-client] Support listing of views #6631

Conversation

yanghua commented Aug 29, 2018

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

yanghua commented Aug 30, 2018

yanghua commented Aug 30, 2018

hequn8128 commented Aug 31, 2018

hequn8128 left a comment • edited

Choose a reason for hiding this comment

hequn8128 Sep 2, 2018

Choose a reason for hiding this comment

hequn8128 Sep 2, 2018

Choose a reason for hiding this comment

hequn8128 Sep 2, 2018

Choose a reason for hiding this comment

hequn8128 Sep 2, 2018

Choose a reason for hiding this comment

yanghua commented Sep 4, 2018

yanghua commented Sep 6, 2018

hequn8128 Sep 7, 2018

Choose a reason for hiding this comment

yanghua Sep 7, 2018

Choose a reason for hiding this comment

hequn8128 Sep 7, 2018

Choose a reason for hiding this comment

yanghua commented Sep 8, 2018

hequn8128 commented Sep 10, 2018

yanghua commented Sep 11, 2018

yanghua commented Sep 17, 2018

yanghua commented Sep 26, 2018

twalthr commented Oct 1, 2018

yanghua commented Mar 12, 2019

yanghua commented May 7, 2020

hequn8128 left a comment •

edited