Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10872] Extend SQL client end-to-end to test KafkaTableSink for kafka connector 0.11 #7100

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@yanghua
Copy link
Contributor

commented Nov 15, 2018

What is the purpose of the change

This pull request extends SQL client end-to-end to test KafkaTableSink for kafka connector 0.11

Brief change log

  • Extend SQL client end-to-end to test KafkaTableSink for kafka connector 0.11

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@yanghua yanghua force-pushed the yanghua:FLINK-10872 branch from 5f25452 to 935c02b Nov 15, 2018

@yanghua yanghua changed the title [Flink 10872] Extend SQL client end-to-end to test KafkaTableSink for kafka connector 0.11 [FLINK-10872] Extend SQL client end-to-end to test KafkaTableSink for kafka connector 0.11 Nov 15, 2018

@yanghua yanghua force-pushed the yanghua:FLINK-10872 branch from 935c02b to 6b98741 Nov 15, 2018

@yanghua

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

@twalthr I cherry-picked your refactor about FLINK-10624 and squashed them so that I can process this issue in parallel. But I split it into a single commit. But in essence, it is still blocked by FLINK-10624.

@yanghua yanghua force-pushed the yanghua:FLINK-10872 branch from 6b98741 to a043dae Nov 15, 2018

@yanghua

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2018

@pnowojski
Copy link
Contributor

left a comment

Thanks @yanghua LGTM.

Once travis is green please drop the pre-commit change and let me know. Side note, please run the test manually in the loop couple of times to make sure that it's stable.

@yanghua yanghua force-pushed the yanghua:FLINK-10872 branch 2 times, most recently from 15f2356 to 74066b3 Nov 15, 2018

@yanghua

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2018

@pnowojski The travis was green before dropping the pre-commit change. I have deleted the commit.

@twalthr twalthr self-assigned this Nov 16, 2018

@twalthr

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2018

Thank you @yanghua. Merging...

asfgit pushed a commit that referenced this pull request Nov 16, 2018

@asfgit asfgit closed this in acd041c Nov 16, 2018

xueyumusic added a commit to xueyumusic/flink that referenced this pull request Nov 24, 2018

TisonKun added a commit to TisonKun/flink that referenced this pull request Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.