New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-8354] Add KafkaDeserializationSchema that directly uses ConsumerRecord #7781
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
cc @alexeyt820 |
4b39787
to
476322f
Compare
476322f
to
529ba9e
Compare
This moves the code to a method in the base class.
5f13be0
to
363aa94
Compare
We now directly use the ConsumerRecord from the Kafka API instead of trying to forward what we need to the deserialization schema ourselves. This makes it more future-proof, if Kafka adds new fields to the ConsumerRecord. The previously used KeyedDeserializationSchema now extends KafkaDeserializationSchema and has a default method to bridge the interface. This way existing uses of KeyedDeserializationSchema still work.
363aa94
to
d39c6c0
Compare
Merged! |
@aljoscha hi, the java file was placed at wrong package |
@lamber-ken How do you mean? |
Now I see, yes, we need to fix this. |
This is a rebased and cleaned-up version of #6615 that only has the Consumer changes.
What is the purpose of the change
ConsumerRecord
, thereby exposing all available Kafka functionality.Brief change log
Verifying this change