[FLINK-12848][core] Consider fieldNames in RowTypeInfo#equals()

[aloyszhang]

What is the purpose of the change

This pr fix the bug of RowTypeInfo#equals(), take fieldNames into consideration.

Brief change log

take fieldNames into consideration in RowTypeInfo#equals()

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
• The serializers: (yes / no / don't know)
• The runtime per-record code paths (performance sensitive): (yes / no / don't know)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
• The S3 file system connector: (yes / no / don't know)

Documentation

• Does this pull request introduce a new feature? (yes / no)

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 82e3196 (Fri Oct 18 02:34:54 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[vim345]

@aloyszhang Is there any reasons you didn't merge this PR?

[aloyszhang]

@vim345
Adding the fieldNames in equals method of RowTypeInfo will make test in ExternalCatalogInsertTest failed. So, we should not fix this problem this way.
BTW , flink-1.9 has no problem described in FLINK-12848. I think this problem has been fixed in 1.9.

[aloyszhang]

@vim345
Hi, sorry for I make a mistake. This problem also appears in flink-1.9 . I will reopen this and try to fix the test failure.

[wuchong]

We will quick fix in FlinkTypeFactory, see #9930
We will fix RowTypeInfo.equals in FLINK-14438 in the future.

Thereby close this PR.