[FLINK-14336][DataStream] Log Exception for failed checkpoint on TaskExecutor side

[klion26]

What is the purpose of the change

Exceptions that are thrown in AsyncCheckpointRunnable#run and subsequently being handled in AsyncCheckpointRunnable#handleExecutionException are never logged on the TaskExecutor side, and are only forwarded to the JobMaster. This PR will log the Exception on TaskExecutor side.

Brief change log

Log Exception for failed checkpoint on TaskExecutor side.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): (no)
• The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
• The serializers: (no)
• The runtime per-record code paths (performance sensitive): (no)
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
• The S3 file system connector: (no)

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)

cc @zentol

[flinkbot]

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit d62e6da (Thu Oct 24 18:05:11 UTC 2019)

Warnings:

• No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

• ❓ 1. The [description] looks good.
• ❓ 2. There is [consensus] that the contribution should go into to Flink.
• ❓ 3. Needs [attention] from.
• ❓ 4. The change fits into the overall [architecture].
• ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
• @flinkbot approve all to approve all aspects
• @flinkbot approve-until architecture to approve everything until architecture
• @flinkbot attention @username1 [@username2 ..] to require somebody's attention
• @flinkbot disapprove architecture to remove an approval you gave earlier

[flinkbot]

CI report:

• d62e6da : FAILURE Build

Bot commands

The @flinkbot bot supports the following commands:

• @flinkbot run travis re-run the last Travis build

[KarmaGYZ]

IMO, it could be an INFO level Log.

[klion26]

First, I want to use WARN or even ERROR level, but the frequency of checkpoint may be too small, we may have logging flood if use INFO or above log level, so I used debug here. If we do not have so frequent checkpoints, we can configure the log level of log-4j properties to show this log. what do you think about this?

[KarmaGYZ]

Make sense. +1 for merge.

[klion26]

kindly ping @zentol

[klion26]

thanks for the review and merging @zentol @KarmaGYZ