Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLUME-2984: Fix OOM in thrift source. Make transport buffer configurable. #102

Open
wants to merge 3 commits into
base: trunk
from

Conversation

@laxman-ch
Copy link
Contributor

laxman-ch commented Dec 26, 2016

No description provided.

Copy link

simonati left a comment

Looks good to me.

Test passes. (mvn test -pl flume-ng-core -Dtest=org.apache.flume.source.TestThriftSource
) Unfortunately the test for the whole module fails for me with - I think irrelevant - missing snappy dependency.

Copy link

simonati left a comment

Transport buffer safetynet was introduced when server was created by the getTThreadedSelectorServer(). Isn't something similar needed when the server creation felt back to getTThreadPoolServer()? Or the issue doesn't persists there?

@bessbd

This comment has been minimized.

Copy link
Member

bessbd commented Feb 8, 2017

@laxman-ch : thank you for the PR!

Is there a way to test this change? (If a unit test is difficult to implement, do you know of any ways to reproduce the issue manually? Ie. "this is the config I use, this is the input that causes OOM".)

@asfgit

This comment has been minimized.

Copy link

asfgit commented Aug 17, 2018

Can one of the admins verify this patch?

waidr pushed a commit to waidr/flume that referenced this pull request Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.