Skip to content
Permalink
Browse files
Do more with ShellCheck (#254)
* Fix numerous issues to make ShellCheck pass across `bin/*` and
  `conf/uno.conf`
* Add GitHub Actions and CI script for automated ShellCheck testing
* Add missing checksum for latest Hadoops still supported by Accumulo
* Fix parameter passing for `--no-deps` flag
* Build SNAPSHOT version with correct version of Guava for Hadoop 3.1
  and later
* Make some long if statements into more concise `&&` syntax for
  readability
* Remove some unnecessary quoting
* Rely on return code for pgrep for many statements that were previously
  relying on its output unnecessarily
* Fix zk dir pattern
* Fix return codes and make rm safer
* Fix ZK capitalization
* Overhaul some of the scripts:
  Consolidate some of the scripts into a commands.sh file and use return
  statements instead of exit statements, as appropriate, for more reliable
  exit behavior for functions.
  • Loading branch information
ctubbsii committed Aug 26, 2020
1 parent 358ad9d commit 76d64de72239c44fdfee9730fdb575bbaefad8d6
Show file tree
Hide file tree
Showing 29 changed files with 623 additions and 780 deletions.
@@ -0,0 +1,37 @@
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
#

name: ShellCheck

on:
push:
branches: [ '*' ]
pull_request:
branches: [ '*' ]

jobs:
shellcheck:
name: ShellCheck
timeout-minutes: 3
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Running shellcheck on bin/** and conf/uno.conf
run: contrib/run-shellcheck

@@ -1,6 +1,6 @@
![Uno][logo]
---
[![Apache License][li]][ll]
[![ShellCheck][ci_img]][ci_link] [![Apache License][li]][ll]

**Uno automates setting up [Apache Accumulo][accumulo] or [Apache Fluo][fluo] (and their dependencies) on a single machine.**

@@ -188,17 +188,19 @@ applications or follow the instructions starting at the [Configure a Fluo applic
section of the Fluo install instructions. These instructions will guide you through the process of
configuring, initializing, and starting your application.

[fluo]: http://fluo.apache.org/
[accumulo]: http://accumulo.apache.org/
[zookeeper]: http://zookeeper.apache.org/
[hadoop]: http://hadoop.apache.org/
[mirrors]: http://www.apache.org/dyn/closer.cgi
[Webindex]: https://github.com/apache/fluo-examples/tree/main/webindex
[Accumulo Proxy]: https://github.com/apache/accumulo-proxy
[Muchos]: https://github.com/apache/fluo-muchos
[Phrasecount]: https://github.com/apache/fluo-examples/tree/main/phrasecount
[Webindex]: https://github.com/apache/fluo-examples/tree/main/webindex
[accumulo]: https://accumulo.apache.org/
[ci_img]: https://github.com/apache/fluo-uno/workflows/ShellCheck/badge.svg
[ci_link]: https://github.com/apache/fluo-uno/actions
[configure]: https://github.com/apache/fluo/blob/main/docs/install.md#configure-a-fluo-application
[li]: http://img.shields.io/badge/license-ASL-blue.svg
[fluo]: https://fluo.apache.org/
[hadoop]: https://hadoop.apache.org/
[li]: https://img.shields.io/badge/license-Apache%202.0-blue.svg
[ll]: https://github.com/apache/fluo-uno/blob/main/LICENSE
[logo]: contrib/uno-logo.png
[Muchos]: https://github.com/apache/fluo-muchos
[mirrors]: https://www.apache.org/dyn/closer.cgi
[ssh-docs]: https://hadoop.apache.org/docs/r3.3.0/hadoop-project-dist/hadoop-common/SingleCluster.html#Setup_passphraseless_ssh
[Accumulo Proxy]: https://github.com/apache/accumulo-proxy
[zookeeper]: https://zookeeper.apache.org/

0 comments on commit 76d64de

Please sign in to comment.