New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#127 Provide instructions for verifying release #129

Merged
merged 5 commits into from Feb 27, 2018

Conversation

Projects
None yet
3 participants
@mikewalch
Member

mikewalch commented Feb 23, 2018

  • Adding instructions for running integrations
  • Will add more instructions for running example applications
#127 Provide instructions for verifying release
* Adding instructions for running integrations
* Will add more instructions for running example applications
@ctubbsii

I like the idea, but I dislike how wordy it is. I think it should be far less descriptive, and much more "copy/paste". I've provided some suggested changes, but am flexible. I really do think it should be bare minimum, though.

Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
@mikewalch

This comment has been minimized.

Show comment
Hide comment
@mikewalch

mikewalch Feb 26, 2018

Member

@ctubbsii, I made a bunch of updates. Let me know what you think.

Member

mikewalch commented Feb 26, 2018

@ctubbsii, I made a bunch of updates. Let me know what you think.

@ctubbsii

ctubbsii approved these changes Feb 26, 2018 edited

I like this version better. I have additional ideas, but I think it might be easier if I submitted my own PR to make the changes in my head, rather than hold up your changes with my feedback.

Show outdated Hide outdated pages/release-process.md Outdated
Show outdated Hide outdated pages/release-process.md Outdated
```shell
./bin/uno setup fluo
eval "$(./bin/uno env)"
```

This comment has been minimized.

@ctubbsii

ctubbsii Feb 26, 2018

Member

Is there more to test here, or just testing that uno can setup fluo?

@ctubbsii

ctubbsii Feb 26, 2018

Member

Is there more to test here, or just testing that uno can setup fluo?

This comment has been minimized.

@mikewalch

mikewalch Feb 26, 2018

Member

This is set up instructions for uno which is need to run example applications. I pushed a commit to make this more clear

@mikewalch

mikewalch Feb 26, 2018

Member

This is set up instructions for uno which is need to run example applications. I pushed a commit to make this more clear

Show outdated Hide outdated pages/release-process.md Outdated
1. Set `FLUO_VERSION` and `FLUO_HASH` in `conf/uno.conf`.
```shell
sed -i "s/export FLUO_VERSION=[^ ]*/export FLUO_VERSION=$RC_VERSION/" conf/uno.conf
sed -i "s/export FLUO_HASH=[^ ]*/export FLUO_HASH=$(shasum -a 256 downloads/fluo-${RC_VERSION}-bin.tar.gz | cut -d ' ' -f 1)/" conf/uno.conf

This comment has been minimized.

@keith-turner

keith-turner Feb 26, 2018

Contributor

this is nice

@keith-turner

keith-turner Feb 26, 2018

Contributor

this is nice

@mikewalch

This comment has been minimized.

Show comment
Hide comment
@mikewalch

mikewalch Feb 27, 2018

Member

I pushed some more commits after this was approved. Is it OK still I merge it?

Member

mikewalch commented Feb 27, 2018

I pushed some more commits after this was approved. Is it OK still I merge it?

@mikewalch mikewalch merged commit a324707 into apache:gh-pages Feb 27, 2018

@mikewalch mikewalch deleted the mikewalch:test-release branch Feb 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment