Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use NewTableConfiguration (and also trivial code cleanup) #960
This PR consists of two commits (best left as two separate commits). The first cleans up some warnings, and formatting. The second makes use of NewTableConfiguration to create tables already pre-loaded with their initial properties at the time of creation.
After switching to NewTableConfiguration, I was reliably able to reproduce the bug which was fixed in #959 and also subsequently able to confirm it was fixed after that was merged in. So, I think this using this feature has merit.
This does require updating the minimum version of Accumulo to 1.7, which I think is fine, since 1.6 is EOL anyway. I also updated the Travis-CI config in the second commit so that tests are run in Travis with 1.8.1 routinely, since that's the current version of Accumulo.
I was thinking of manually testing this changes, but then it occurred to me it would be nice to test the following in a IT
These test could possibly be done in FluoAdminImplIT.
The reason I wanted to test manually is because I had angst about the copied code from Accumulo. If iterators were not properly set, then other ITs would probably catch that. However if loc groups were not properly set, nothing would catch that (it would just cause performance problems). So I think checking loc gorups after init is a good test even w/o these changes. These test could be done in this issue or a follow on issue.