[server] Respect log.* options for table#3358
Open
zuston wants to merge 3 commits into
Open
Conversation
zuston
commented
May 22, 2026
Comment on lines
112
to
434
| @@ -417,6 +418,17 @@ private static void checkTieredLog(Configuration tableConf) { | |||
| } | |||
| } | |||
|
|
|||
| private static void checkLogSegmentFileSize(Configuration tableConf) { | |||
| if (tableConf.contains(ConfigOptions.LOG_SEGMENT_FILE_SIZE) | |||
| && tableConf.get(ConfigOptions.LOG_SEGMENT_FILE_SIZE).getBytes() | |||
| > Integer.MAX_VALUE) { | |||
| throw new InvalidConfigException( | |||
| String.format( | |||
| "Invalid configuration for %s, it must be less than or equal %d bytes.", | |||
| ConfigOptions.LOG_SEGMENT_FILE_SIZE.key(), Integer.MAX_VALUE)); | |||
| } | |||
| } | |||
|
|
|||
| private static void checkPartition( | |||
| Configuration tableConf, List<String> partitionKeys, RowType rowType) { | |||
| boolean isPartitioned = !partitionKeys.isEmpty(); | |||
Member
Author
There was a problem hiding this comment.
When surfacing this part of the code, could we move the option validation logic into the option definitions themselves? For example:
public static final ConfigOption<Integer> TABLE_TIERED_LOG_LOCAL_SEGMENTS =
key("table.log.tiered.local-segments")
.intType()
.defaultValue(2)
.valueValidator(v -> v > 0, "must be greater than zero")
.withDescription(
"The number of log segments to retain in local for each table when log tiered storage is enabled. "
+ "It must be greater that 0. The default is 2.");
lilei1128
reviewed
May 22, 2026
|
|
||
| static { | ||
| TABLE_OPTIONS = extractConfigOptions("table."); | ||
| TABLE_OPTIONS.put( |
There was a problem hiding this comment.
Could log.index.file-size also be supported？
Member
Author
There was a problem hiding this comment.
sure. this is the first phase for this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Brief change log
Tests
API and Format
Documentation