From bcdfbdfa137db16dae3fc6a88048dd282e44df8b Mon Sep 17 00:00:00 2001 From: chaokunyang Date: Sun, 6 Aug 2023 15:47:33 +0800 Subject: [PATCH 1/3] use java.lang.ClassValue to cache lookup --- .../src/main/java/io/fury/util/unsafe/_JDKAccess.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java b/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java index 6919c60a86..00e4bffc1e 100644 --- a/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java +++ b/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java @@ -73,11 +73,18 @@ public class _JDKAccess { } } + private static final ClassValue lookup_ = new ClassValue() { + @Override + protected Lookup computeValue(Class type) { + return _Lookup._trustedLookup(type); + } + }; + // CHECKSTYLE.OFF:MethodName public static Lookup _trustedLookup(Class objectClass) { // CHECKSTYLE.ON:MethodName - return _Lookup._trustedLookup(objectClass); + return lookup_.get(objectClass); } public static T tryMakeFunction( From 59ba567ec721341319db63b8fd3c733c3cfabff2 Mon Sep 17 00:00:00 2001 From: chaokunyang Date: Sun, 6 Aug 2023 16:12:17 +0800 Subject: [PATCH 2/3] lint code --- .../src/main/java/io/fury/util/unsafe/_JDKAccess.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java b/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java index 00e4bffc1e..f425f0e567 100644 --- a/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java +++ b/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java @@ -73,7 +73,7 @@ public class _JDKAccess { } } - private static final ClassValue lookup_ = new ClassValue() { + private static final ClassValue lookupCache = new ClassValue() { @Override protected Lookup computeValue(Class type) { return _Lookup._trustedLookup(type); @@ -84,7 +84,7 @@ protected Lookup computeValue(Class type) { public static Lookup _trustedLookup(Class objectClass) { // CHECKSTYLE.ON:MethodName - return lookup_.get(objectClass); + return lookupCache.get(objectClass); } public static T tryMakeFunction( From 7172479908acd82a4cdcf8a921dee13430893943 Mon Sep 17 00:00:00 2001 From: chaokunyang Date: Sun, 6 Aug 2023 16:17:14 +0800 Subject: [PATCH 3/3] lint code --- .../main/java/io/fury/util/unsafe/_JDKAccess.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java b/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java index f425f0e567..775247c460 100644 --- a/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java +++ b/java/fury-core/src/main/java/io/fury/util/unsafe/_JDKAccess.java @@ -73,12 +73,13 @@ public class _JDKAccess { } } - private static final ClassValue lookupCache = new ClassValue() { - @Override - protected Lookup computeValue(Class type) { - return _Lookup._trustedLookup(type); - } - }; + private static final ClassValue lookupCache = + new ClassValue() { + @Override + protected Lookup computeValue(Class type) { + return _Lookup._trustedLookup(type); + } + }; // CHECKSTYLE.OFF:MethodName