Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
GEODE-5766: Fixes google-readability-namespace-comments warning
  • Loading branch information
jake-at-work committed Oct 9, 2018
1 parent 0806074 commit 156431c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .clang-tidy
@@ -1,6 +1,6 @@
---
Checks: '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments'
WarningsAsErrors: 'google-build-using-namespace,google-readability-redundant-smartptr-get,google-explicit-constructor,google-global-names-in-headers,google-runtime-int,google-readability-casting'
WarningsAsErrors: 'google-build-using-namespace,google-readability-redundant-smartptr-get,google-explicit-constructor,google-global-names-in-headers,google-runtime-int,google-readability-casting,google-readability-namespace-comments'
HeaderFilterRegex: '.*'
AnalyzeTemporaryDtors: false
FormatStyle: file
Expand Down
2 changes: 1 addition & 1 deletion cppcache/src/MapSegment.hpp
Expand Up @@ -66,7 +66,7 @@ class ACE_Equal_To<std::shared_ptr<apache::geode::client::CacheableKey>> {
}
};

} // namespace ACE_VERSIONED_NAMESPACE_NAME
} // namespace ACE_VERSIONED_NAMESPACE_NAME NOLINT

namespace apache {
namespace geode {
Expand Down
4 changes: 2 additions & 2 deletions cppcache/src/SerializationRegistry.hpp
Expand Up @@ -48,7 +48,7 @@
#include "MemberListForVersionStamp.hpp"
#include "config.h"

namespace ACE_VERSIONED_NAMESPACE_NAME {
namespace ACE_VERSIONED_NAMESPACE_NAME { // NOLINT

#if defined(_MACOSX)
// TODO CMake check type int64_t
Expand All @@ -71,7 +71,7 @@ class ACE_Hash<DSCode> {
}
};

} // namespace ACE_VERSIONED_NAMESPACE_NAME
} // namespace ACE_VERSIONED_NAMESPACE_NAME NOLINT

namespace apache {
namespace geode {
Expand Down
7 changes: 2 additions & 5 deletions cppcache/src/TcrConnectionManager.hpp
Expand Up @@ -25,9 +25,9 @@
#include <list>
#include <unordered_map>

#include <ace/config-lite.h>
#include <ace/Map_Manager.h>
#include <ace/Semaphore.h>
#include <ace/config-lite.h>
#include <ace/Versioned_Namespace.h>
#include <ace/Recursive_Thread_Mutex.h>

Expand All @@ -38,13 +38,10 @@
#include "ThinClientRedundancyManager.hpp"
#include "ExpiryTaskManager.hpp"

namespace ACE_VERSIONED_NAMESPACE_NAME {
class ACE_Task_Base;
} // namespace ACE_VERSIONED_NAMESPACE_NAME

namespace apache {
namespace geode {
namespace client {

class TcrConnection;
class TcrEndpoint;
class TcrMessage;
Expand Down

0 comments on commit 156431c

Please sign in to comment.