Skip to content
Permalink
Browse files
GEODE-5839: Fixes explicit constructor definition.
* Cleanup .clang-tidy files.
  • Loading branch information
pivotal-jbarrett committed Oct 10, 2018
1 parent ecc62a6 commit cdcb703ed46e06318a074c90f137842c739ef5ae
Showing 3 changed files with 6 additions and 4 deletions.
@@ -1,6 +1,6 @@
---
Checks: '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments,-clang-analyzer-core.uninitialized.UndefReturn,-clang-analyzer-core.UndefinedBinaryOperatorResult,-clang-analyzer-optin.cplusplus.VirtualCall'
WarningsAsErrors: 'clang-analyzer-optin.performance.*,clang-analyzer-core.*,clang-analyzer-unix.*,clang-diagnostic-*,google-*,clang-analyzer-cplusplus.*,clang-analyzer-security.insecureAPI.*,clang-analyzer-deadcode.*'
WarningsAsErrors: '*'
HeaderFilterRegex: '.*'
FormatStyle: file
...
@@ -120,7 +120,7 @@ class APACHE_GEODE_EXPORT CacheableArrayPrimitive
inline CacheableArrayPrimitive() = default;

template <typename TT>
CacheableArrayPrimitive(TT&& value) : m_value(std::forward<TT>(value)) {}
explicit CacheableArrayPrimitive(TT&& value) : m_value(std::forward<TT>(value)) {}

~CacheableArrayPrimitive() noexcept override = default;

@@ -1,12 +1,14 @@
---
Checks: '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-clang-analyzer-unix.cstring.NullArg'
WarningsAsErrors: '*,-google-default-arguments'
Checks: '-*,clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-alpha*,google-*,-google-readability-todo,-google-runtime-references,-google-default-arguments,-clang-analyzer-unix.cstring.NullArg'
WarningsAsErrors: '*'
HeaderFilterRegex: '.*'
FormatStyle: file
...

# Disable Checks
# google-runtime-references - We have diverged from this rule due to both legacy and disagreement with the rule.
# google-readability-todo - Adds current user name when fix applied.

# TODO - Fix these checks
# google-default-arguments
# clang-analyzer-unix.cstring.NullArg - Generates errors in Boost, how do we ignore?

0 comments on commit cdcb703

Please sign in to comment.