GEODE-9321: Fix possible race condition on ITs#809
Merged
Conversation
- Solved a possible race condition in ServerDisconnectWithListener TS due to the fact that there was no check to verify the server was actually stopped. - Also added gmock_actions helper to avoid duplication. - Modified RegisterKeysTest to use gmock_actions helper.
gaussianrecurrence
force-pushed
the
feature/GEODE-9321
branch
from
290ebf4 to
f0cb1a6
Compare
pdxcodemonkey
approved these changes
Jun 8, 2021
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
- Solved a possible race condition in ServerDisconnectWithListener TS due to the fact that there was no check to verify the server was actually stopped. - Also added gmock_actions helper to avoid duplication. - Modified RegisterKeysTest to use gmock_actions helper.
davebarnes97
pushed a commit
to davebarnes97/geode-native
that referenced
this pull request
Feb 9, 2022
- Solved a possible race condition in ServerDisconnectWithListener TS due to the fact that there was no check to verify the server was actually stopped. - Also added gmock_actions helper to avoid duplication. - Modified RegisterKeysTest to use gmock_actions helper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to the fact that there was no check to verify the server was
actually stopped.