Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5001 Update dependency versions #1741

Closed
wants to merge 1 commit into from

Conversation

metatype
Copy link
Contributor

@metatype metatype commented Apr 5, 2018

guava 24.0-jre -> 24.1-jre
HikariCP 2.7.6 -> 3.0.0
jackson 2.9.4 -> 2.9.5
log4j 2.8.2 -> 2.11.0
protoc 3.5.1 -> 3.5.1-1

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • [N/A] Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

guava 24.0-jre -> 24.1-jre
HikariCP 2.7.6 -> 3.0.0
jackson 2.9.4 -> 2.9.5
log4j 2.8.2 -> 2.11.0
protoc 3.5.1 -> 3.5.1-1
@metatype
Copy link
Contributor Author

metatype commented Apr 5, 2018

I'm expecting further changes will be required for the session replication tests. Last time I ran them against log4j 2.10.0 stuff broke. Details forthcoming.

@PurelyApplied
Copy link
Member

I've run a precheckin based off (a merge-resolved copy of) this PR. As per the previous attempt, the SessionReplicationIntegrationJUnitTest blows up badly.

Originally, the error appeared to be JOG4J2-2152. In the discussion of the related ticket LOG4J2-2266, it looks like the true error stems from how Log4j2 interacts with the class loader, which in turn causes tests run with the PerTestClassLoaderRunner to fail.

I've opened GEODE-5189 to address the test refactoring. Updating Log4j will be blocked until this can be addressed.

@PurelyApplied
Copy link
Member

As an aside, it may be worth noting in dependency-versions.properties that both Jetty and Tomcat have hard-coded versions defined in some respective tests. I'm not familiar with those tests in particular, just something I noticed. It might be worth having, though...


diff --git a/gradle/dependency-versions.properties b/gradle/dependency-versions.properties
index bf4876c..42077bb 100644
--- a/gradle/dependency-versions.properties
+++ b/gradle/dependency-versions.properties
@@ -55,6 +55,8 @@ javax.resource-api.version = 1.7
 javax.servlet-api.version = 3.1.0
 javax.transaction-api.version = 1.2
 jedis.version = 2.9.0
+# The jetty version is also hard-coded in geode-assembly:test
+# at o.a.g.sessions.tests.GenericAppServerInstall.java
 jetty.version = 9.4.8.v20171121
 jgroups.version = 3.6.14.Final
 jmock.version = 2.8.2
@@ -96,6 +98,8 @@ springfox.version=2.8.0
 stephenc-findbugs.version = 1.3.9-1
 system-rules.version = 1.17.1
 tempus-fugit.version = 1.1
+# Multiple versions of tomcat are hard-coded in geode-assembly:test
+# at o.a.g.session.tests.TomcatInstall
 tomcat6.version = 6.0.37
 tomcat7.version = 7.0.73
 tomcat8.version = 8.5.9

@PurelyApplied
Copy link
Member

PurelyApplied commented May 9, 2018

It looks like #1938 should fix the outstanding issues. I'll go ahead and merge the new HEAD of develop with this and rerun precheckin.

@PurelyApplied
Copy link
Member

The updated precheckin run for my branch of this work came back green. I don't know if you want to incorporate that into this PR or if I should open my own, but there it is.

@metatype
Copy link
Contributor Author

metatype commented May 11, 2018 via email

@PurelyApplied
Copy link
Member

Closing in favor of #1951.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants