New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-5001 Update dependency versions #1741
Conversation
guava 24.0-jre -> 24.1-jre HikariCP 2.7.6 -> 3.0.0 jackson 2.9.4 -> 2.9.5 log4j 2.8.2 -> 2.11.0 protoc 3.5.1 -> 3.5.1-1
I'm expecting further changes will be required for the session replication tests. Last time I ran them against log4j 2.10.0 stuff broke. Details forthcoming. |
I've run a precheckin based off (a merge-resolved copy of) this PR. As per the previous attempt, the Originally, the error appeared to be JOG4J2-2152. In the discussion of the related ticket LOG4J2-2266, it looks like the true error stems from how Log4j2 interacts with the class loader, which in turn causes tests run with the I've opened GEODE-5189 to address the test refactoring. Updating Log4j will be blocked until this can be addressed. |
As an aside, it may be worth noting in
|
It looks like #1938 should fix the outstanding issues. I'll go ahead and merge the new HEAD of |
The updated precheckin run for my branch of this work came back green. I don't know if you want to incorporate that into this PR or if I should open my own, but there it is. |
Go ahead and create a new PR based on your changes.
Anthony
… On May 11, 2018, at 10:10 AM, Patrick Rhomberg ***@***.***> wrote:
The updated precheckin run for my branch of this work <https://github.com/PurelyApplied/geode/tree/geode-5001> came back green. I don't know if you want to incorporate that into this PR or if I should open my own, but there it is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1741 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACqT2Zuv6PLHbo7b78TkYPXAgEsR77n5ks5txcYLgaJpZM4TIqxd>.
|
Closing in favor of #1951. |
guava 24.0-jre -> 24.1-jre
HikariCP 2.7.6 -> 3.0.0
jackson 2.9.4 -> 2.9.5
log4j 2.8.2 -> 2.11.0
protoc 3.5.1 -> 3.5.1-1
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?[N/A] Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.