New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding IntelliJ setup instructions to BUILDING.md #2456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmellawatt
requested review from
metatype,
jake-at-work,
nabarunnag and
jhuynh1
September 11, 2018 22:10
mcmellawatt
force-pushed
the
docs/intellijbuild
branch
from
September 11, 2018 22:29
6fa10d0
to
7be91ff
Compare
moleske
reviewed
Sep 12, 2018
moleske
reviewed
Sep 12, 2018
kirklund
requested changes
Sep 12, 2018
mcmellawatt
force-pushed
the
docs/intellijbuild
branch
2 times, most recently
from
September 12, 2018 16:55
079fb59
to
e5d8bff
Compare
mcmellawatt
force-pushed
the
docs/intellijbuild
branch
from
September 12, 2018 16:56
e5d8bff
to
686d824
Compare
mcmellawatt
force-pushed
the
docs/intellijbuild
branch
from
September 12, 2018 17:40
98ae8fd
to
3b5f3bf
Compare
Made all the requested changes - thanks for all the feedback! |
jake-at-work
requested changes
Sep 12, 2018
kirklund
approved these changes
Sep 12, 2018
jake-at-work
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
Has your PR been rebased against the latest commit within the target branch (typically
develop
)?Is your initial contribution a single, squashed commit?
Does
gradlew build
run cleanly?Have you written or updated unit tests to verify your changes?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.