New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-5885: Exclude geode-core from geode-[jd]unit dependencies. #2640

Merged
merged 13 commits into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@PurelyApplied
Contributor

PurelyApplied commented Oct 16, 2018

Branched from PR #2611, to avoid significant merge conflicts with same. Review should begin with sha ae36279.
Now that #2661 has merged, the entire diff should consist only of the exclude module: 'geode-core' changes.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

PurelyApplied and others added some commits Sep 28, 2018

GEODE-5879 Enforces consistent syntax in gradle dependency declaration
Always use a parentesis around the thing being depended on.
Do not space pad between configuration and parenthesis before dependency
Prefer single quote around the package names

Co-authored-by: Robert Houghton <rhoughton@pivotal.io>
Co-authored-by: Patrick Rhomberg <prhomberg@pivotal.io>
GEODE-5885: Exclude geode-core from geode-[jd]unit dependencies.
* This will not be necessary once the java-library plugin is stable with publishing.
* At that future date, we may use the implementation configuration rather than compile in geode-[jd]unit, avoiding leaking geode-core to other modules.
@PurelyApplied

This comment has been minimized.

Contributor

PurelyApplied commented Oct 16, 2018

Looks like DistributedTest and UpdateTest aren't going to finish, after some Concourse instability / "max containers reached" errors.

@smgoller

seems legit

@PurelyApplied PurelyApplied merged commit fa34122 into apache:develop Oct 19, 2018

6 checks passed

concourse-ci/AcceptanceTest Concourse CI build success
Details
concourse-ci/DistributedTest Concourse CI build success
Details
concourse-ci/IntegrationTest Concourse CI build success
Details
concourse-ci/StressNewTest Concourse CI build success
Details
concourse-ci/UnitTest Concourse CI build success
Details
concourse-ci/UpgradeTest Concourse CI build success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment