Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-6918: Cleanup ServerLauncher #3780

Merged

Conversation

@kirklund
Copy link
Contributor

kirklund commented Jul 3, 2019

  • Remove unnecessary uses of this
  • Replace \n with System.lineSeperator()
  • Remove unnecessary qualifications
  • Fix misc IDE warnings
  • Remove commented out code
  • Minor formatting changes

Co-authored-by: Aaron Lindsey alindsey@pivotal.io

* Remove unnecessary uses of this
* Replace \n with System.lineSeperator()
* Remove unnecessary qualifications
* Fix misc IDE warnings
* Remove commented out code
* Minor formatting changes

Co-authored-by: Aaron Lindsey <alindsey@pivotal.io>
@kirklund kirklund force-pushed the kirklund:GEODE-6918-cleanup-ServerLauncher branch from de0d9ca to 6d6de7a Jul 3, 2019
@kirklund kirklund changed the title DRAFT: GEODE-6918: Cleanup ServerLauncher GEODE-6918: Cleanup ServerLauncher Jul 5, 2019
@kirklund kirklund marked this pull request as ready for review Jul 5, 2019
@kirklund kirklund requested review from demery-pivotal, moleske and mhansonp Jul 5, 2019
@moleske
moleske approved these changes Jul 5, 2019
Copy link
Member

moleske left a comment

This seems pretty straight forward

@kirklund kirklund merged commit ed96ac9 into apache:develop Jul 8, 2019
8 checks passed
8 checks passed
concourse-ci/AcceptanceTestOpenJDK11 Concourse CI build success
Details
concourse-ci/Build Concourse CI build success
Details
concourse-ci/DistributedTestOpenJDK11 Concourse CI build success
Details
concourse-ci/IntegrationTestOpenJDK11 Concourse CI build success
Details
concourse-ci/StressNewTestOpenJDK11 Concourse CI build success
Details
concourse-ci/UnitTestOpenJDK11 Concourse CI build success
Details
concourse-ci/UnitTestOpenJDK8 Concourse CI build success
Details
concourse-ci/UpgradeTestOpenJDK11 Concourse CI build success
Details
@kirklund kirklund deleted the kirklund:GEODE-6918-cleanup-ServerLauncher branch Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.