Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-7853: Remove unused field #4777

Merged
merged 1 commit into from Mar 6, 2020

Conversation

jujoramos
Copy link
Contributor

Remove unused field and avoid unnecessary calls to
Logger.isTraceEnabled().

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

Remove unused field and avoid unnecessary calls to
Logger.isTraceEnabled().
Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very unused to me! There's other code cleanliness that could happen if you feel like but I'm personally always happy with any removal of unused code

@jujoramos jujoramos merged commit a9a7d15 into apache:develop Mar 6, 2020
@jujoramos jujoramos deleted the feature/GEODE-7853 branch March 6, 2020 18:53
igodwin pushed a commit to igodwin/geode that referenced this pull request Mar 11, 2020
Remove unused field and avoid unnecessary calls to
Logger.isTraceEnabled().
echobravopapa pushed a commit that referenced this pull request Mar 20, 2020
Remove unused field and avoid unnecessary calls to
Logger.isTraceEnabled().

(cherry picked from commit a9a7d15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants