GEODE-8423: Updates Redis API for Geode docs 1.13 #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebarnes97
requested changes
Aug 11, 2020
There was a problem hiding this comment.
Excellent contribution! One change requested...
+1 for worthy improvements and timely action (v1.13 back-port needs to occur soon).
+0 for promising what the functionality will be but isn't, yet. ("Once completed it will allow...drop-in replacement") Sounds like a promise, makes me uncomfortable. But was already there, so OK.
-1 for "is under development and is expected to be released in Geode 1.14."
Never promise delivery in a specific version number. Please truncate to "is under development" (my preference) or replace with something like "is under development, and is expected to be available in a forthcoming release".
Thanks!
dschneider-pivotal
pushed a commit
that referenced
this pull request
Aug 12, 2020
(cherry picked from commit 140de5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for Redis API for Geode that will currently be published for 1.13 are not accurate and need to be updated.