Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-8761: detect stuck ServerConnection threads #6226

Merged

Conversation

dschneider-pivotal
Copy link
Contributor

The previous fix for GEODE-8761 ended up monitoring the thread that created the server connection
instead of the thread that was executing its run() method.
Now the threadMonitorExecutor is created in the run() method
which causes the correct thread id to be set on it.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:

Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.

which causes the correct thread id to be set on it.
@dschneider-pivotal dschneider-pivotal merged commit 89200dc into apache:develop Mar 30, 2021
@dschneider-pivotal dschneider-pivotal deleted the GEODE-8761-take2 branch March 30, 2021 20:44
dschneider-pivotal added a commit to dschneider-pivotal/geode that referenced this pull request Mar 30, 2021
* The threadMonitorExecutor is now created in the run() method
which causes the correct thread id to be set on it.

* changed threadMonitorExecutor field from protected to private

(cherry picked from commit 89200dc)
nabarunnag pushed a commit that referenced this pull request Mar 31, 2021
* The threadMonitorExecutor is now created in the run() method
which causes the correct thread id to be set on it.

* changed threadMonitorExecutor field from protected to private

(cherry picked from commit 89200dc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants