Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEODE-9354: Extract and test ArgumentRedactorRegex #6641

Merged

Conversation

kirklund
Copy link
Contributor

@kirklund kirklund commented Jun 24, 2021

  1. get ArgumentRedactor under better unit testing
  2. refactor ArgumentRedactor: isolate parts of it for better testing, use strategy to try out impls using String and CLI libraries
  3. fix lots of issues in regex found by the new unit testing

@kirklund kirklund marked this pull request as draft June 24, 2021 20:51
@kirklund kirklund changed the title GEODE-9354: Extract and test ArgumentRedactorRegex DRAFT: GEODE-9354: Extract and test ArgumentRedactorRegex Jun 24, 2021
@kirklund kirklund force-pushed the GEODE-9354-ArgumentRedactorRegex-tests branch from 695f522 to ce853ad Compare June 24, 2021 20:52
@kirklund kirklund changed the title DRAFT: GEODE-9354: Extract and test ArgumentRedactorRegex GEODE-9354: Extract and test ArgumentRedactorRegex Jun 24, 2021
@kirklund kirklund marked this pull request as ready for review June 24, 2021 23:24
Copy link
Contributor

@Bill Bill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

Rename ArgumentRedactorJUnitTest as ArgumentRedactorTest.
Reorganize some tests and reformat some code in ArgumentRedactor.
@kirklund kirklund force-pushed the GEODE-9354-ArgumentRedactorRegex-tests branch from ce853ad to 3aa30e8 Compare July 21, 2021 21:06
@kirklund kirklund force-pushed the GEODE-9354-ArgumentRedactorRegex-tests branch 2 times, most recently from 55fc8f7 to 57ae8c2 Compare July 21, 2021 21:13
@kirklund kirklund force-pushed the GEODE-9354-ArgumentRedactorRegex-tests branch from 57ae8c2 to 7e9198e Compare July 21, 2021 22:29
Copy link
Contributor

@mhansonp mhansonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you should/could have a "sensitive string list" that stores your test strings in one place and uses it everywhere, the reason I say that is that you have a lot of tests that test one string and it might be more interesting to just have a single list, so you modify the list and it runs against both sets of tests automatically.

@kirklund kirklund merged commit 693e18c into apache:develop Jul 26, 2021
@kirklund kirklund deleted the GEODE-9354-ArgumentRedactorRegex-tests branch July 26, 2021 16:53
kirklund added a commit to kirklund/geode that referenced this pull request Aug 9, 2021
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
kirklund added a commit to kirklund/geode that referenced this pull request Aug 9, 2021
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
kirklund added a commit to kirklund/geode that referenced this pull request Aug 9, 2021
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
kirklund added a commit that referenced this pull request Aug 12, 2021
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
kirklund added a commit that referenced this pull request Aug 12, 2021
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
kirklund added a commit that referenced this pull request Aug 12, 2021
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
mkevo pushed a commit to Nordix/geode that referenced this pull request Jan 21, 2022
…che#6749)

* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest.
* Reorganize and reformat ArgumentRedactor and its tests.
* Fix issues in regex found by new tests.

(cherry picked from commit 693e18c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants