-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEODE-9354: Extract and test ArgumentRedactorRegex #6641
GEODE-9354: Extract and test ArgumentRedactorRegex #6641
Conversation
kirklund
commented
Jun 24, 2021
•
edited
Loading
edited
- get ArgumentRedactor under better unit testing
- refactor ArgumentRedactor: isolate parts of it for better testing, use strategy to try out impls using String and CLI libraries
- fix lots of issues in regex found by the new unit testing
695f522
to
ce853ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve.
Rename ArgumentRedactorJUnitTest as ArgumentRedactorTest.
Reorganize some tests and reformat some code in ArgumentRedactor.
ce853ad
to
3aa30e8
Compare
55fc8f7
to
57ae8c2
Compare
57ae8c2
to
7e9198e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like you should/could have a "sensitive string list" that stores your test strings in one place and uses it everywhere, the reason I say that is that you have a lot of tests that test one string and it might be more interesting to just have a single list, so you modify the list and it runs against both sets of tests automatically.
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest. * Reorganize and reformat ArgumentRedactor and its tests. * Fix issues in regex found by new tests. (cherry picked from commit 693e18c)
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest. * Reorganize and reformat ArgumentRedactor and its tests. * Fix issues in regex found by new tests. (cherry picked from commit 693e18c)
* Rename ArgumentRedactorJUnitTest to ArgumentRedactorTest. * Reorganize and reformat ArgumentRedactor and its tests. * Fix issues in regex found by new tests. (cherry picked from commit 693e18c)